Summary: | [GTK] Move scrollbar rendering out of gtk2drawing.c | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, eric, gustavo, webkit.review.bot, xan.lopez | ||||||
Priority: | P3 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | 51155 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Martin Robinson
2011-01-20 13:01:24 PST
Created attachment 79644 [details]
Patch
Comment on attachment 79644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79644&action=review > Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:58 > + "slider_width", &m_thumbFatness, > + "trough_border", &m_troughBorderWidth, I will change the underscores here to dashes before landing. would be nice to see the gtk ews results. (In reply to comment #3) > would be nice to see the gtk ews results. I can repost it after the blocking bug has landed. Created attachment 79787 [details]
Patch
Attachment 79787 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:62: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:198: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 79787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79787&action=review > Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:112 > + // properly the theme may draw not draw the thumb borders properly. s/draw not/not/, right? > Source/WebCore/platform/gtk/ScrollbarThemeGtk2.cpp:186 > + gfloat arrowScaling; Xan does not approve of using g* types when they're just typedefs of the standard C ones. > Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:155 > +void WidgetRenderingContext::gtkPaintBox(const IntRect& rect, GtkWidget* widget, GtkStateType stateType, GtkShadowType shadowType, const gchar* detail, bool adjustAllocation) Would it hurt to remove the bool and always perform the allocation? I mean, except for the (negligible?) extra work? It might make this more future-proof, and we can toss this additional argument. Committed r77960: <http://trac.webkit.org/changeset/77960> Comment on attachment 79787 [details]
Patch
Thanks for the review! Landed with your suggestions.
|