Bug 52817

Summary: QtTestBrowser should have seperate menu for Settings
Product: WebKit Reporter: mansi mithal <mansi.mithal>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, laszlo.gombos, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Adds a new menu item and move the settings under it. none

mansi mithal
Reported 2011-01-20 08:47:11 PST
QtTestBrowser should have seperate menu for "Settings" and move "Enable interrupting JS scripts" and "Enable js pop up windows" under the "Settings" menu
Attachments
Adds a new menu item and move the settings under it. (2.66 KB, patch)
2011-01-20 12:19 PST, mansi mithal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mansi mithal
Comment 1 2011-01-20 12:19:59 PST
Created attachment 79632 [details] Adds a new menu item and move the settings under it.
Antonio Gomes
Comment 2 2011-01-20 13:20:57 PST
Comment on attachment 79632 [details] Adds a new menu item and move the settings under it. Why not moving Spatial Navigation, Frame flattening, etc at once?
Antonio Gomes
Comment 3 2011-01-20 13:22:07 PST
Also, you can use the "Depends on" and "Blocks" fields to set inter-dependencies between bugs.
WebKit Commit Bot
Comment 4 2011-01-20 14:48:26 PST
The commit-queue encountered the following flaky tests while processing attachment 79632 [details]: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-01-20 14:51:04 PST
Comment on attachment 79632 [details] Adds a new menu item and move the settings under it. Clearing flags on attachment: 79632 Committed r76286: <http://trac.webkit.org/changeset/76286>
WebKit Commit Bot
Comment 6 2011-01-20 14:51:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.