Bug 52815

Summary: Web Inspector: enable resource agent upon request.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change yurys: review+

Pavel Feldman
Reported 2011-01-20 08:11:02 PST
We should not send network-related notifications unless front-end is interested.
Attachments
[PATCH] Proposed change (12.34 KB, patch)
2011-01-20 08:15 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-01-20 08:15:43 PST
Created attachment 79602 [details] [PATCH] Proposed change
Andrey Kosyakov
Comment 2 2011-01-20 08:27:44 PST
Comment on attachment 79602 [details] [PATCH] Proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=79602&action=review Looks good. > Source/WebCore/inspector/InspectorResourceAgent.h:52 > class InspectorObject; nit: this looks out of order.
Yury Semikhatsky
Comment 3 2011-01-20 08:37:44 PST
Comment on attachment 79602 [details] [PATCH] Proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=79602&action=review > Source/WebCore/inspector/InspectorController.cpp:491 > +InspectorResourceAgent* InspectorController::resourceAgent() We should be consistent: either agents are enabled explicitly or on demand.
Pavel Feldman
Comment 4 2011-01-20 08:49:39 PST
Committed r76249: <http://trac.webkit.org/changeset/76249>
WebKit Review Bot
Comment 5 2011-01-20 09:12:43 PST
http://trac.webkit.org/changeset/76249 might have broken Windows Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.