Bug 52815

Summary: Web Inspector: enable resource agent upon request.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change yurys: review+

Description Pavel Feldman 2011-01-20 08:11:02 PST
We should not send network-related notifications unless front-end is interested.
Comment 1 Pavel Feldman 2011-01-20 08:15:43 PST
Created attachment 79602 [details]
[PATCH] Proposed change
Comment 2 Andrey Kosyakov 2011-01-20 08:27:44 PST
Comment on attachment 79602 [details]
[PATCH] Proposed change

View in context: https://bugs.webkit.org/attachment.cgi?id=79602&action=review

Looks good.

> Source/WebCore/inspector/InspectorResourceAgent.h:52
>  class InspectorObject;

nit: this looks out of order.
Comment 3 Yury Semikhatsky 2011-01-20 08:37:44 PST
Comment on attachment 79602 [details]
[PATCH] Proposed change

View in context: https://bugs.webkit.org/attachment.cgi?id=79602&action=review

> Source/WebCore/inspector/InspectorController.cpp:491
> +InspectorResourceAgent* InspectorController::resourceAgent()

We should be consistent: either agents are enabled explicitly or on demand.
Comment 4 Pavel Feldman 2011-01-20 08:49:39 PST
Committed r76249: <http://trac.webkit.org/changeset/76249>
Comment 5 WebKit Review Bot 2011-01-20 09:12:43 PST
http://trac.webkit.org/changeset/76249 might have broken Windows Debug (Build)