Bug 52741

Summary: Add run-time enable support for the web audio API
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, fishd, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch fishd: review+, fishd: commit-queue-

Chris Rogers
Reported 2011-01-19 14:12:12 PST
Add run-time enable support for the web audio API
Attachments
Patch (14.24 KB, patch)
2011-01-19 14:17 PST, Chris Rogers 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-01-19 14:17:33 PST
Created attachment 79481 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2011-01-19 14:26:06 PST
Comment on attachment 79481 [details] Patch R=me for the WebCore and WebKit/chromium/ changes. I'm not the best reviewer for the WebKit/{mac,win} changes, but they look reasonable to me. One question about the WebKit/win/ code though... why not update WebPreferences for that port? Or, put another way, why bother updating WebPreferences for WebKit/mac/ if you are not also going to do so for WebKit/win/?
WebKit Review Bot
Comment 3 2011-01-19 18:08:32 PST
Attachment 79481 [details] did not build on mac: Build output: http://queues.webkit.org/results/7594232
Chris Rogers
Comment 4 2011-01-21 13:43:53 PST
Darin, the reason the Safari mac port stuff is in this patch is because the web audio API already works there, but the Safari win isn't really ported yet so we don't need the complete implementation for that yet.
Chris Rogers
Comment 5 2011-01-21 13:44:26 PST
Committed r76390: <http://trac.webkit.org/changeset/76390>
WebKit Review Bot
Comment 6 2011-01-21 14:50:17 PST
http://trac.webkit.org/changeset/76390 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/select-box.html transforms/2d/zoom-menulist.html
Note You need to log in before you can comment on or make changes to this bug.