| Summary: | Add run-time enable support for the web audio API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, fishd, peter, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Rogers
2011-01-19 14:12:12 PST
Created attachment 79481 [details]
Patch
Comment on attachment 79481 [details]
Patch
R=me for the WebCore and WebKit/chromium/ changes. I'm not the best reviewer for the WebKit/{mac,win} changes, but they look reasonable to me. One question about the WebKit/win/ code though... why not update WebPreferences for that port? Or, put another way, why bother updating WebPreferences for WebKit/mac/ if you are not also going to do so for WebKit/win/?
Attachment 79481 [details] did not build on mac: Build output: http://queues.webkit.org/results/7594232 Darin, the reason the Safari mac port stuff is in this patch is because the web audio API already works there, but the Safari win isn't really ported yet so we don't need the complete implementation for that yet. Committed r76390: <http://trac.webkit.org/changeset/76390> http://trac.webkit.org/changeset/76390 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/select-box.html transforms/2d/zoom-menulist.html |