Bug 52731

Summary: Web Inspector: further simplify InspectorState.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change yurys: review+

Description Pavel Feldman 2011-01-19 12:17:45 PST 
This change moved XHR logging flag into console agent, removes InspectorState pushing to the front-end.
Comment 1 Pavel Feldman 2011-01-19 12:19:59 PST 
Created attachment 79463 [details]
[PATCH] Proposed change
Comment 2 WebKit Review Bot 2011-01-19 12:21:42 PST 
Attachment 79463 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorConsoleAgent.h:73:  The parameter name "enabled" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorState.h:75:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorState.h:81:  The parameter name "propertyId" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorState.h:82:  The parameter name "propertyId" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorState.h:83:  The parameter name "propertyId" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorState.h:84:  The parameter name "propertyId" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ilya Tikhonovsky 2011-01-19 12:40:41 PST 
Comment on attachment 79463 [details]
[PATCH] Proposed change

View in context: https://bugs.webkit.org/attachment.cgi?id=79463&action=review

> Source/WebCore/ChangeLog:9
> +        removes InspectorState pushing to the front-end.No new tests. (OOPS!)

Nit: please fix.

looks good to me
Comment 4 Yury Semikhatsky 2011-01-20 04:43:23 PST 
Comment on attachment 79463 [details]
[PATCH] Proposed change

Please fix style errors and ChangeLog description before landing.
Comment 5 Pavel Feldman 2011-01-20 04:50:03 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/inspector/Inspector.idl
	M	Source/WebCore/inspector/InspectorConsoleAgent.cpp
	M	Source/WebCore/inspector/InspectorConsoleAgent.h
	M	Source/WebCore/inspector/InspectorController.cpp
	M	Source/WebCore/inspector/InspectorController.h
	M	Source/WebCore/inspector/InspectorState.cpp
	M	Source/WebCore/inspector/InspectorState.h
	M	Source/WebCore/inspector/front-end/ConsoleView.js
	M	Source/WebCore/inspector/front-end/inspector.js
Committed r76230
Comment 6 WebKit Review Bot 2011-01-20 05:21:08 PST 
http://trac.webkit.org/changeset/76230 might have broken Qt Linux Release