Bug 52651

Summary: Add chromium bundled audio spatialization resources to WebAudio.grd
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, eric, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch kbr: review+

Chris Rogers
Reported 2011-01-18 12:48:57 PST
Add WebKitAudio.grd for chromium bundled audio spatialization resources
Attachments
Patch (40.44 KB, patch)
2011-01-18 12:51 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (38.80 KB, patch)
2011-01-18 15:10 PST, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (40.29 KB, patch)
2011-01-19 15:52 PST, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-01-18 12:51:02 PST
Created attachment 79311 [details] Patch
Chris Rogers
Comment 2 2011-01-18 12:52:10 PST
Soon I'll be putting up a corresponding chromium-side patch.
Chris Rogers
Comment 3 2011-01-18 15:10:47 PST
Created attachment 79341 [details] Patch
Chris Rogers
Comment 4 2011-01-18 15:12:29 PST
Last patch fixes "Source" path problem in .grd file
Tony Chang
Comment 5 2011-01-19 09:30:16 PST
Comment on attachment 79341 [details] Patch I would just put these into WebKit.grd because it's simpler. There's not really any benefit to adding another grd file.
Chris Rogers
Comment 6 2011-01-19 15:52:30 PST
Created attachment 79509 [details] Patch
Chris Rogers
Comment 7 2011-01-19 15:53:35 PST
Simplified to add the resources to WebKit.grd as you suggest.
Chris Rogers
Comment 8 2011-01-20 18:48:49 PST
Tony, can you please have a look at this. You've already approved the corresponding chromium patch. Thanks!
Kenneth Russell
Comment 9 2011-01-21 11:59:41 PST
Comment on attachment 79509 [details] Patch rs=me
Chris Rogers
Comment 10 2011-01-21 12:30:00 PST
Committed r76380: <http://trac.webkit.org/changeset/76380>
Note You need to log in before you can comment on or make changes to this bug.