Bug 52608 – Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of three bools

• Component: HTML Editing
• Status: RESOLVED FIXED

[Hajime Morrita]

Coined at Bug 5241. Refactoring three bool parameters into one enum.

[Hajime Morrita]

Created attachment 79380 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 79380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79380&action=review

> Source/WebCore/page/EventHandler.cpp:2670
> -    RefPtr<TextEvent> event = TextEvent::create(m_frame->domWindow(), text, TextEvent::selectInputType(isLineBreak, isBackTab));
> +    RefPtr<TextEvent> event = TextEvent::create(m_frame->domWindow(), text, inputType);

Only concern I have with this change is that we may permit inputType to be TextEventInputPaste or TextEventInputDrop here. Can we add an assertion that this can only be Keyboard, LineBreak, or BackTab?

[Ryosuke Niwa]

Thanks for making this change!

[Ryosuke Niwa]

Comment on attachment 79380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79380&action=review

> Source/WebCore/dom/TextEventInputType.h:9
> +/*
> + * Copyright (C) 2010 Google, Inc. All Rights Reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright

Oops, we shouldn't be claiming to be the author if we're just moving it here.

[Ryosuke Niwa]

Comment on attachment 79380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79380&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22369
>  				F3D4C47912E07663003DA150 /* InspectorBrowserDebuggerAgent.h in Headers */,
> +				A77B41A012E675A90054343D /* TextEventInputType.h in Headers */,

You probably want to put this in the right place as well.

[Ryosuke Niwa]

Comment on attachment 79380 [details]
Patch

(In reply to comment #4)
> Oops, we shouldn't be claiming to be the author if we're just moving it here.

I just realized you're the original author of this enum in http://trac.webkit.org/changeset/65287. I put my r+ back.

Please still correct the location of TextEventInputType.h in WebCore.xcodeproj/project.pbxproj as noted above.

[Hajime Morrita]

> I just realized you're the original author of this enum in http://trac.webkit.org/changeset/65287. I put my r+ back.
> 
> Please still correct the location of TextEventInputType.h in WebCore.xcodeproj/project.pbxproj as noted above.

Thanks! I'll land this after fixing project.pbxproj.

[Hajime Morrita]

Committed r76098: <http://trac.webkit.org/changeset/76098>