Bug 52607

Summary: Some WebKit2 layout tests crash due to focus being on a frame in the page cache
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: New BugsAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Description Maciej Stachowiak 2011-01-17 19:30:41 PST 
Some WebKit2 layout tests crash due to focus being on a frame in the page cache
Comment 1 Maciej Stachowiak 2011-01-17 19:33:25 PST 
Created attachment 79239 [details]
Patch
Comment 2 mitz 2011-01-17 19:41:09 PST 
Comment on attachment 79239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79239&action=review

I know that in single-frame pages we try to maintain the focused element upon navigation back to a cached page. Does this change affect this behavior? Does it already not work for pages with subframes?

> Source/WebCore/ChangeLog:15
> +        goes in the page cache, rest focus to the main frame.

Typo: rest.
Comment 3 mitz 2011-01-17 19:47:49 PST 
Comment on attachment 79239 [details]
Patch

WebKit is already failing to maintain focus in a subframe across navigation through the page cache, which is arguably a bug, but not something this patch changes, so r+
Comment 4 Maciej Stachowiak 2011-01-17 19:49:26 PST 
Committed r75994: <http://trac.webkit.org/changeset/75994>