Summary: | [Qt] Drag and Drop does not appear to work properly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ragner Magalhaes <ragner.magalhaes> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | benjamin, diegohcg, kenneth, kling, luiz, menard, tonikitoo, yael | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Ragner Magalhaes
2011-01-17 15:21:57 PST
Created attachment 79227 [details]
Patch 01
Comment on attachment 79227 [details] Patch 01 View in context: https://bugs.webkit.org/attachment.cgi?id=79227&action=review > Source/WebCore/ChangeLog:8 > + Check timerId's consistency before kill it to prevent kill invalid timer. You need to explain how this related-to/affects the drag and drop Also, please rephrase. Maybe something like: Ensure that timerId is valid before *killing* it, to prevent *killing an* invalid timer. (In reply to comment #2) > (From update of attachment 79227 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79227&action=review > > > Source/WebCore/ChangeLog:8 > > + Check timerId's consistency before kill it to prevent kill invalid timer. > > You need to explain how this related-to/affects the drag and drop Hi, after the fix of the drag and drop I was getting a warning message like this "Application asked to unregister timer 0x%x which is not registered in this thread. Fix application." so I just fixed the code that was causing this warning. It doesn't affect the drag and drop. I was just getting this warnings. Should I remove this fix from drag/drop's patch ? > > Also, please rephrase. Maybe something like: Ensure that timerId is valid before *killing* it, to prevent *killing an* invalid timer. More about this warning message: http://bugreports.qt.nokia.com/browse/QTBUG-16175 (In reply to comment #3) > It doesn't affect the drag and drop. I was just getting this warnings. > > Should I remove this fix from drag/drop's patch ? Yep, patch should be doing two unrelated change. Please open a second bug for this and just include that part of the patch there. Created attachment 80865 [details]
Patch 02
Comment on attachment 80865 [details]
Patch 02
The patch make sense to me after reading the documentation of drag and drop in Qt.
Ok, then. Ragner, can we test this somehow? autotest even... Auto-test not really. QTestLib is not very nice for that. But a manual test why not, with instructions. (In reply to comment #8) > Ok, then. Ragner, can we test this somehow? autotest even... Hi tonikitoo, I tested it manually with this demo http://html5demos.com/drag Looks good to me too :) Comment on attachment 80865 [details]
Patch 02
Ok, lets go with a manual test for now, and please explain in the changelog what is needed for it to be tested.
*** This bug has been marked as a duplicate of bug 56486 *** |