Bug 52601

Summary: [Qt] Drag and Drop does not appear to work properly
Product: WebKit Reporter: Ragner Magalhaes <ragner.magalhaes>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: benjamin, diegohcg, kenneth, kling, luiz, menard, tonikitoo, yael
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch 01
kenneth: review-
Patch 02 tonikitoo: review-

Description Ragner Magalhaes 2011-01-17 15:21:57 PST
Here is a testing page: http://html5demos.com/drag
Also you can open some web page with a text input on it and try to drag some text onto the input box.
Comment 1 Ragner Magalhaes 2011-01-17 16:20:36 PST
Created attachment 79227 [details]
Patch 01
Comment 2 Kenneth Rohde Christiansen 2011-01-17 23:42:52 PST
Comment on attachment 79227 [details]
Patch 01

View in context: https://bugs.webkit.org/attachment.cgi?id=79227&action=review

> Source/WebCore/ChangeLog:8
> +        Check timerId's consistency before kill it to prevent kill invalid timer.

You need to explain how this related-to/affects the drag and drop

Also, please rephrase. Maybe something like: Ensure that timerId is valid before *killing* it, to prevent *killing an* invalid timer.
Comment 3 Ragner Magalhaes 2011-01-18 06:04:43 PST
(In reply to comment #2)
> (From update of attachment 79227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79227&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Check timerId's consistency before kill it to prevent kill invalid timer.
> 
> You need to explain how this related-to/affects the drag and drop

Hi,
after the fix of the drag and drop I was getting a warning message like this "Application asked to unregister timer 0x%x which is not registered in this thread. Fix application."

so I just fixed the code that was causing this warning.

It doesn't affect the drag and drop. I was just getting this warnings.

Should I remove this fix from drag/drop's patch ?


> 
> Also, please rephrase. Maybe something like: Ensure that timerId is valid before *killing* it, to prevent *killing an* invalid timer.
Comment 4 Ragner Magalhaes 2011-01-18 06:12:54 PST
More about this warning message: http://bugreports.qt.nokia.com/browse/QTBUG-16175
Comment 5 Benjamin Poulain 2011-01-28 18:53:12 PST
(In reply to comment #3)
> It doesn't affect the drag and drop. I was just getting this warnings.
> 
> Should I remove this fix from drag/drop's patch ?

Yep, patch should be doing two unrelated change. Please open a second bug for this and just include that part of the patch there.
Comment 6 Ragner Magalhaes 2011-02-01 18:06:02 PST
Created attachment 80865 [details]
Patch 02
Comment 7 Alexis Menard (darktears) 2011-02-14 09:18:23 PST
Comment on attachment 80865 [details]
Patch 02

The patch make sense to me after reading the documentation of drag and drop in Qt.
Comment 8 Antonio Gomes 2011-02-14 09:28:04 PST
Ok, then. Ragner, can we test this somehow? autotest even...
Comment 9 Alexis Menard (darktears) 2011-02-14 10:42:26 PST
Auto-test not really. QTestLib is not very nice for that. But a manual test why not, with instructions.
Comment 10 Ragner Magalhaes 2011-02-15 07:01:07 PST
(In reply to comment #8)
> Ok, then. Ragner, can we test this somehow? autotest even...
Hi tonikitoo,
I tested it manually with this demo http://html5demos.com/drag
Comment 11 Yael 2011-02-17 08:32:52 PST
Looks good to me too :)
Comment 12 Antonio Gomes 2011-02-17 13:32:12 PST
Comment on attachment 80865 [details]
Patch 02

Ok, lets go with a manual test for now, and please explain in the changelog what is needed for it to be tested.
Comment 13 Benjamin Poulain 2011-04-05 07:13:26 PDT

*** This bug has been marked as a duplicate of bug 56486 ***