Bug 52587

Summary: WKCACFLayerRenderer is hard to use
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch cmarrin: review+

Description Adam Roben (:aroben) 2011-01-17 10:16:13 PST
WKCACFLayerRenderer is hard to use
Comment 1 Adam Roben (:aroben) 2011-01-17 10:22:11 PST
Created attachment 79185 [details]
Patch
Comment 2 Chris Marrin 2011-01-17 10:41:20 PST
Comment on attachment 79185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79185&action=review

r=me, assuming the animationStarted logic is actually working. But I don't see anywhere in this patch where it's getting called.

> Source/WebCore/ChangeLog:8
> +        accomplished in other ways.)

What other ways?

> WebKit/win/WebView.cpp:-6520
> -

Who is calling notifyAnimationStarted now?
Comment 3 Adam Roben (:aroben) 2011-01-17 10:47:40 PST
Comment on attachment 79185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79185&action=review

>> Source/WebCore/ChangeLog:8
>> +        accomplished in other ways.)
> 
> What other ways?

http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp?rev=75262#L469

I'll note this in the ChangeLog.

>> WebKit/win/WebView.cpp:-6520
>> -
> 
> Who is calling notifyAnimationStarted now?

See above. :-)
Comment 4 Chris Marrin 2011-01-17 11:08:07 PST
(In reply to comment #3)
> (From update of attachment 79185 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79185&action=review
> 
> >> Source/WebCore/ChangeLog:8
> >> +        accomplished in other ways.)
> > 
> > What other ways?
> 
> http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp?rev=75262#L469
> 
> I'll note this in the ChangeLog.

Thanks.

> 
> >> WebKit/win/WebView.cpp:-6520
> >> -
> > 
> > Who is calling notifyAnimationStarted now?
> 
> See above. :-)

I made that change 10 days ago. You expect me to remember something like that? :-)

I was confused because I tried doing this several different ways. The code you axed was just a victim I didn't clean up.
Comment 5 Adam Roben (:aroben) 2011-01-17 17:55:00 PST
Committed r75988: <http://trac.webkit.org/changeset/75988>