Bug 52564

Summary:

Build fails when Inspector is disabled

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, pfeldman

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Fixed compilation when Inspector is disabled	pfeldman: review-

Konstantin Tokarev

Reported 2011-01-17 03:41:37 PST

Attached patch fixes this problem

Attachments
Fixed compilation when Inspector is disabled (1.56 KB, patch) 2011-01-17 03:43 PST, Konstantin Tokarev	pfeldman: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Konstantin Tokarev

Comment 1 2011-01-17 03:43:51 PST

Created attachment 79149 [details] Fixed compilation when Inspector is disabled

Kent Tamura

Comment 2 2011-01-17 17:49:57 PST

Comment on attachment 79149 [details] Fixed compilation when Inspector is disabled Looks good.

WebKit Commit Bot

Comment 3 2011-01-18 04:45:11 PST

Comment on attachment 79149 [details] Fixed compilation when Inspector is disabled Clearing flags on attachment: 79149 Committed r76017: <http://trac.webkit.org/changeset/76017>

WebKit Commit Bot

Comment 4 2011-01-18 04:45:16 PST

All reviewed patches have been landed. Closing bug.

Pavel Feldman

Comment 5 2011-01-18 05:33:01 PST

Comment on attachment 79149 [details] Fixed compilation when Inspector is disabled This patch is wrong, InspectorInstrumentation:: can be called with no guard. Please roll it out.

Konstantin Tokarev

Comment 6 2011-01-18 05:35:56 PST

> This patch is wrong, InspectorInstrumentation:: can be called with no guard. Compilation fails without guard

Pavel Feldman

Comment 7 2011-01-18 05:51:00 PST

(In reply to comment #6) > > This patch is wrong, InspectorInstrumentation:: can be called with no guard. > > Compilation fails without guard I can see Qt Linux minimal bots doing fine before this change and after I rolled it out in the r76018: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/16270.

Konstantin Tokarev

Comment 8 2011-01-19 01:42:28 PST

(In reply to comment #7) > (In reply to comment #6) > > > This patch is wrong, InspectorInstrumentation:: can be called with no guard. > > > > Compilation fails without guard > > I can see Qt Linux minimal bots doing fine before this change and after I rolled it out in the r76018: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/16270. You're right, sorry

Note You need to log in before you can comment on or make changes to this bug.