Bug 52564

Summary: Build fails when Inspector is disabled
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Fixed compilation when Inspector is disabled pfeldman: review-

Description Konstantin Tokarev 2011-01-17 03:41:37 PST 
Attached patch fixes this problem
Comment 1 Konstantin Tokarev 2011-01-17 03:43:51 PST 
Created attachment 79149 [details]
Fixed compilation when Inspector is disabled
Comment 2 Kent Tamura 2011-01-17 17:49:57 PST 
Comment on attachment 79149 [details]
Fixed compilation when Inspector is disabled

Looks good.
Comment 3 WebKit Commit Bot 2011-01-18 04:45:11 PST 
Comment on attachment 79149 [details]
Fixed compilation when Inspector is disabled

Clearing flags on attachment: 79149

Committed r76017: <http://trac.webkit.org/changeset/76017>
Comment 4 WebKit Commit Bot 2011-01-18 04:45:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Pavel Feldman 2011-01-18 05:33:01 PST 
Comment on attachment 79149 [details]
Fixed compilation when Inspector is disabled

This patch is wrong, InspectorInstrumentation:: can be called with no guard. Please roll it out.
Comment 6 Konstantin Tokarev 2011-01-18 05:35:56 PST 
> This patch is wrong, InspectorInstrumentation:: can be called with no guard. 

Compilation fails without guard
Comment 7 Pavel Feldman 2011-01-18 05:51:00 PST 
(In reply to comment #6)
> > This patch is wrong, InspectorInstrumentation:: can be called with no guard. 
> 
> Compilation fails without guard

I can see Qt Linux minimal bots doing fine before this change and after I rolled it out in the r76018: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/16270.
Comment 8 Konstantin Tokarev 2011-01-19 01:42:28 PST 
(In reply to comment #7)
> (In reply to comment #6)
> > > This patch is wrong, InspectorInstrumentation:: can be called with no guard. 
> > 
> > Compilation fails without guard
> 
> I can see Qt Linux minimal bots doing fine before this change and after I rolled it out in the r76018: http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/16270.

You're right, sorry