Bug 52528 – Strict mode restrictions on arguments and eval usage aren't complete

• Component: New Bugs
• Status: RESOLVED FIXED

[Oliver Hunt]

Strict mode restrictions on arguments and eval usage aren't complete

[Oliver Hunt]

Created attachment 79092 [details]
Patch

[Geoffrey Garen]

+            isEvalOrArguments = m_globalData->propertyNames->eval == *m_lastIdentifier || m_globalData->propertyNames->arguments == *m_lastIdentifier;

We usually write comparisons like this in the opposite order.

Did you test the performance of this change? I think it's worth a SunSpider --parse-only run.

[Oliver Hunt]

(In reply to comment #2)
> +            isEvalOrArguments = m_globalData->propertyNames->eval == *m_lastIdentifier || m_globalData->propertyNames->arguments == *m_lastIdentifier;
> 
> We usually write comparisons like this in the opposite order.

Just heading out, i'll fix this when i get back

> 
> Did you test the performance of this change? I think it's worth a SunSpider --parse-only run.
Of course :p

sunspider says no change but over many runs i estimate it is actually a slowdown, just very very slight.  I don't believe that there's anything that can be done about it though.

[Geoffrey Garen]

Comment on attachment 79092 [details]
Patch

If a slowdown happens in a forest, and SunSpider doesn't measure it, does it actually exist?

r=me with that one change

[Oliver Hunt]

Committed r75896: <http://trac.webkit.org/changeset/75896>