| Summary: | Perform some forward declaration | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | abarth, buildbot, dglazkov, eric, gustavo, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||
| Hardware: | Other | ||||||||||||||||||||
| OS: | OS X 10.5 | ||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 52451 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Tony Gentilcore
2011-01-15 16:38:22 PST
Created attachment 79081 [details]
Patch
Attachment 79081 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7508087 Attachment 79081 [details] did not build on qt: Build output: http://queues.webkit.org/results/7525104 Attachment 79081 [details] did not build on win: Build output: http://queues.webkit.org/results/7552089 Attachment 79081 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7509104 Created attachment 79083 [details]
Patch
Attachment 79083 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7515102 Attachment 79083 [details] did not build on win: Build output: http://queues.webkit.org/results/7509108 Created attachment 79087 [details]
Patch
Attachment 79083 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7527100 Attachment 79087 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7502111 Created attachment 79104 [details]
Patch
Comment on attachment 79104 [details]
Patch
Might be worth-while to wait for the GTK EWS bot to process this patch before landing.
Attachment 79104 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7515173 Created attachment 79469 [details]
Patch
Created attachment 79471 [details]
Patch
Created attachment 79473 [details]
Patch
Attachment 79473 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7616203 Created attachment 79480 [details]
Patch
Comment on attachment 79480 [details]
Patch
Looks good. I love changes like these. As long as it doesn’t break the build!
(In reply to comment #20) > (From update of attachment 79480 [details]) > Looks good. I love changes like these. As long as it doesn’t break the build! The EWS bots are proving indispensable in finding the transitive deps. Unfortunately there's a lot of noise in patch building, but at least I can get it working on mac, then use EWS to get it working elsewhere. Don't worry, I won't land until it passes all. BTW, there's some discussion in bug 52451 about how worthwhile these changes are. They seem to make a difference when I build locally, but the trend doesn't show through to the buildbot. Do you have any thoughts on how worthwhile of an effort this is? Committed r76170: <http://trac.webkit.org/changeset/76170> http://trac.webkit.org/changeset/76170 might have broken Chromium Win Release |