Bug 52461

Summary:

Layout test media/video-zoom-controls is flakey

Product:

WebKit

Reporter:

Steve Lacey <sjl>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, eric, levin, scherkus, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Steve Lacey 2011-01-14 11:22:13 PST

The video sources need to be set before initializing the test in the same way as all the other tests similar to this one, otherwise the canplaythrough event can be missed.

Comment 1 Steve Lacey 2011-01-14 11:31:44 PST

Created attachment 78968 [details]
Patch

Comment 2 Eric Carlson 2011-01-14 12:32:23 PST

I can't imagine how this will change anything since the inline script element should run before the body's onload fires, but we will see.

Comment 3 WebKit Commit Bot 2011-01-14 12:39:19 PST

Comment on attachment 78968 [details]
Patch

Rejecting attachment 78968 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 2

Last 500 characters of output:
75f416f5360 (refs/remotes/trunk)
	A	LayoutTests/fast/block/merge-anonymous-block-remove-child-crash2-expected.txt
	A	LayoutTests/fast/block/merge-anonymous-block-remove-child-crash2.html
	M	LayoutTests/ChangeLog
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/rendering/RenderBlock.cpp
	M	Source/WebCore/rendering/RenderBlock.h
r75810 = ef0f5542d66a05c4f90c44cad6dc7c2361e7c2b2 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/7603054

Comment 4 Steve Lacey 2011-01-14 13:25:29 PST

I believe that prior to the change the canplaythough event could fire prior to the onload event and the listener being setup. At least that was by observation...

Comment 5 David Levin 2011-01-14 13:30:30 PST

Comment on attachment 78968 [details]
Patch

Setting cq+ I think there was a "race condition" on the commit due the ChangeLog being modified after the change was applied but before the commit took place (since it failed at the git svn dcommit stage).

Comment 6 Eric Carlson 2011-01-14 13:32:51 PST

(In reply to comment #4)
> I believe that prior to the change the canplaythough event could fire prior to the onload event and the listener being setup. At least that was by observation...

Absolutely true, I misread the original test!

Comment 7 Eric Seidel (no email) 2011-01-14 13:35:59 PST

Sorry, we should teach the cq how to handle that.  It already handles "checkout out of date", but doesn't handle merge conflicts on rebase like that.. yet.

Comment 8 Eric Seidel (no email) 2011-01-14 13:40:49 PST

I wonder if any of bug 25465, bug 50918 or bug 52415 should be duped against this one.

Comment 9 Eric Seidel (no email) 2011-01-14 13:41:51 PST

Is the init() call not needed?  It seems to be removed in this patch.

Comment 10 Steve Lacey 2011-01-14 13:43:26 PST

The init() is still there at the end of the onload=""

Comment 11 Steve Lacey 2011-01-14 13:45:49 PST

52415 isn't a dupe. I raised it initially (and will fix it) - the chromium baselines need to be built for this test, but during the baselining I found this bug in the actual test.

Comment 12 WebKit Commit Bot 2011-01-14 14:45:40 PST

Comment on attachment 78968 [details]
Patch

Clearing flags on attachment: 78968

Committed r75824: <http://trac.webkit.org/changeset/75824>

Comment 13 WebKit Commit Bot 2011-01-14 14:45:46 PST

All reviewed patches have been landed.  Closing bug.