Summary: | Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Andrey Kosyakov
2011-01-14 08:54:30 PST
Created attachment 78948 [details]
patch
Comment on attachment 78948 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=78948&action=review > Source/WebCore/inspector/front-end/NetworkManager.js:183 > + this._finishResource(resource, time); We should not do two refreshes per operation. > Source/WebCore/inspector/front-end/NetworkManager.js:221 > + this._startResource(resource); Audits will break on web sockets. > Source/WebCore/inspector/front-end/NetworkManager.js:258 > + this._finishResource(resource, time); ditto Created attachment 79180 [details]
patch to land
(In reply to comment #2) > (From update of attachment 78948 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78948&action=review > > > Source/WebCore/inspector/front-end/NetworkManager.js:183 > > + this._finishResource(resource, time); > > We should not do two refreshes per operation. As discussed, I would rather leave this as is: NetworkPanel.refreshResources() is cheap, as it postpones actual DOM refresh to an async timer event (so two refreshes will still be one). OTOH, I'm reluctant to put any skipRefresh-like flags into the interface, especially in view of planned transition to events. > > Source/WebCore/inspector/front-end/NetworkManager.js:221 > > + this._startResource(resource); > > Audits will break on web sockets. > > > Source/WebCore/inspector/front-end/NetworkManager.js:258 > > + this._finishResource(resource, time); > > ditto We just use these events there for updating the progress indicator, so it won'r really break. Thanks, though, fixed this. Comment on attachment 78948 [details] patch Cleared Pavel Feldman's review+ from obsolete attachment 78948 [details] so that this bug does not appear in http://webkit.org/pending-commit. Manually committed r75950: http://trac.webkit.org/changeset/75950 |