|Summary:||Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources|
|Product:||WebKit||Reporter:||Andrey Kosyakov <caseq>|
|Component:||Web Inspector (Deprecated)||Assignee:||Andrey Kosyakov <caseq>|
|Severity:||Normal||CC:||apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys|
|Version:||528+ (Nightly build)|
Description Andrey Kosyakov 2011-01-14 08:54:30 PST
webInspector.resources.onFinished is not fired for resources that were redirected. In general, the logic of starting/finishing is often inconsistent in NetworkManager: sometimes, not all consumers are notified on resource being finished, sometimes resources are not cleaned up upon finishing from NetworkManager._resourcesById.
Comment 2 Pavel Feldman 2011-01-17 01:59:32 PST
Comment on attachment 78948 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=78948&action=review > Source/WebCore/inspector/front-end/NetworkManager.js:183 > + this._finishResource(resource, time); We should not do two refreshes per operation. > Source/WebCore/inspector/front-end/NetworkManager.js:221 > + this._startResource(resource); Audits will break on web sockets. > Source/WebCore/inspector/front-end/NetworkManager.js:258 > + this._finishResource(resource, time); ditto
Comment 4 Andrey Kosyakov 2011-01-17 09:19:43 PST
(In reply to comment #2) > (From update of attachment 78948 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78948&action=review > > > Source/WebCore/inspector/front-end/NetworkManager.js:183 > > + this._finishResource(resource, time); > > We should not do two refreshes per operation. As discussed, I would rather leave this as is: NetworkPanel.refreshResources() is cheap, as it postpones actual DOM refresh to an async timer event (so two refreshes will still be one). OTOH, I'm reluctant to put any skipRefresh-like flags into the interface, especially in view of planned transition to events. > > Source/WebCore/inspector/front-end/NetworkManager.js:221 > > + this._startResource(resource); > > Audits will break on web sockets. > > > Source/WebCore/inspector/front-end/NetworkManager.js:258 > > + this._finishResource(resource, time); > > ditto We just use these events there for updating the progress indicator, so it won'r really break. Thanks, though, fixed this.
Comment 5 Eric Seidel (no email) 2011-01-31 16:07:09 PST
Comment on attachment 78948 [details] patch Cleared Pavel Feldman's review+ from obsolete attachment 78948 [details] so that this bug does not appear in http://webkit.org/pending-commit.