Bug 52434

Summary:

[GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp

Product:

WebKit

Reporter:

Joone Hur <joone>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dpranke, eric, gustavo, levin, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Proposed Patch	levin: review+
Proposed Patch2	levin: review-
Proposed Patch3	none

Joone Hur

Reported 2011-01-14 01:19:54 PST

Some functions use GOwnPtr, but others still use gchar & char pointers.

Attachments
Proposed Patch (2.84 KB, patch) 2011-01-14 01:34 PST, Joone Hur	levin: review+	Details Formatted Diff Diff
Proposed Patch2 (2.84 KB, patch) 2011-01-14 02:19 PST, Joone Hur	levin: review-	Details Formatted Diff Diff
Proposed Patch3 (2.83 KB, patch) 2011-01-14 03:42 PST, Joone Hur	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Joone Hur

Comment 1 2011-01-14 01:34:33 PST

Created attachment 78907 [details] Proposed Patch

Joone Hur

Comment 2 2011-01-14 02:19:16 PST

Created attachment 78915 [details] Proposed Patch2 Sorry, I have submitted the patch again..

David Levin

Comment 3 2011-01-14 02:40:58 PST

Comment on attachment 78915 [details] Proposed Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=78915&action=review Now that I had a second chance to look at it. I think it could be slightly better since you are making this change. Sorry for not noticing last time. > Source/WebCore/platform/gtk/FileSystemGtk.cpp:51 > return string; I wonder why you don't just do return String(escapedString.get()); And the same for the other three places where you did a change.

Joone Hur

Comment 4 2011-01-14 03:42:24 PST

Created attachment 78923 [details] Proposed Patch3 Thanks for the review.

Martin Robinson

Comment 5 2011-01-14 08:41:30 PST

Thanks for the cleanup, Joone!

Joone Hur

Comment 6 2011-01-14 08:51:54 PST

(In reply to comment #5) > Thanks for the cleanup, Joone! You're welcome :-)

WebKit Commit Bot

Comment 7 2011-01-14 09:02:23 PST

The commit-queue encountered the following flaky tests while processing attachment 78923 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 8 2011-01-14 09:03:58 PST

Comment on attachment 78923 [details] Proposed Patch3 Clearing flags on attachment: 78923 Committed r75797: <http://trac.webkit.org/changeset/75797>

WebKit Commit Bot

Comment 9 2011-01-14 09:04:06 PST

All reviewed patches have been landed. Closing bug.

David Levin

Comment 10 2011-01-14 09:15:55 PST

(In reply to comment #7) > The commit-queue encountered the following flaky tests while processing attachment 78923 [details]: > > The commit-queue is continuing to process your patch. Eric, something went wrong here ^^^.

Eric Seidel (no email)

Comment 11 2011-01-14 11:58:38 PST

I think the python tests flaked and it got confused by that: https://webkit-commit-queue.appspot.com/results/7492048 We need to disable that python test. We've known it's been flaky for some time.

Dirk Pranke

Comment 12 2011-01-14 12:41:54 PST

(In reply to comment #11) > I think the python tests flaked and it got confused by that: > https://webkit-commit-queue.appspot.com/results/7492048 > > We need to disable that python test. We've known it's been flaky for some time. Perhaps a better solution would be to fix that test? :)

Note You need to log in before you can comment on or make changes to this bug.