Bug 52433

Summary: WebCore::cache() is named too generally
Product: WebKit Reporter: Yuzo Fujishima <yuzo>
Component: Page LoadingAssignee: Yuzo Fujishima <yuzo>
Status: RESOLVED FIXED    
Severity: Minor CC: abarth, ap, buildbot, commit-queue, eric, gustavo, koivisto, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Fix compilation errors for gtk, qt, wx
none
Fix for WebKit2 none

Description Yuzo Fujishima 2011-01-14 01:15:52 PST
In my opinion, WebCore::cache() is named too generally.
Being a global function, it should be renamed to something more specific.
Comment 1 Yuzo Fujishima 2011-01-14 01:21:43 PST
Created attachment 78906 [details]
Patch
Comment 2 WebKit Review Bot 2011-01-14 01:25:09 PST
Attachment 78906 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7513032
Comment 3 Early Warning System Bot 2011-01-14 01:34:50 PST
Attachment 78906 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7587026
Comment 4 Yuzo Fujishima 2011-01-14 01:39:11 PST
Created attachment 78908 [details]
Fix compilation errors for gtk, qt, wx
Comment 5 Build Bot 2011-01-14 01:42:37 PST
Attachment 78906 [details] did not build on win:
Build output: http://queues.webkit.org/results/7498039
Comment 6 Yuzo Fujishima 2011-01-14 02:05:32 PST
Created attachment 78914 [details]
Fix for WebKit2
Comment 7 Alexey Proskuryakov 2011-01-14 10:32:21 PST
CC'ing folks who were leading MemoryCache renaming.
Comment 8 WebKit Commit Bot 2011-01-14 17:59:21 PST
Comment on attachment 78914 [details]
Fix for WebKit2

Clearing flags on attachment: 78914

Committed r75857: <http://trac.webkit.org/changeset/75857>
Comment 9 WebKit Commit Bot 2011-01-14 17:59:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Review Bot 2011-01-14 19:12:23 PST
http://trac.webkit.org/changeset/75857 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/workers/shared-worker-shared.html
fast/workers/worker-close-more.html
fast/workers/worker-constructor.html
http/tests/websocket/tests/workers/close-in-shared-worker.html
http/tests/workers/shared-worker-importScripts.html
http/tests/workers/worker-importScripts.html