| Summary: | [chromium] Tiled compositor should use texture manager | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrienne Walker <enne> | ||||
| Component: | WebCore Misc. | Assignee: | Adrienne Walker <enne> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, enne, jamesr, kbr, nduca, vangelis | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Adrienne Walker
2011-01-13 18:01:19 PST
This is a needed first step prior to tiling the content and image layers. This change will get the root layer's behavior closer to how these other layers behave. Created attachment 78992 [details]
Patch
Comment on attachment 78992 [details]
Patch
Looks good as far as I can tell from code inspection. Please make sure these changes are fully tested in the browser as well as with the automated tests.
Yeah, I know our compositing testing infrastructure is not the best yet, so I did a number of manual browser tests (which the ChangeLog entry was too narrow to contain). I opened up a number of pages (in the same render process) that used the compositor, resized the browser, switched tabs, closed tabs, and made sure both scrollbars still behaved as expected. Comment on attachment 78992 [details] Patch Clearing flags on attachment: 78992 Committed r76165: <http://trac.webkit.org/changeset/76165> All reviewed patches have been landed. Closing bug. |