Bug 52418

Summary: [chromium] Tiled compositor should use texture manager
Product: WebKit Reporter: Adrienne Walker <enne>
Component: WebCore Misc.Assignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enne, jamesr, kbr, nduca, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Adrienne Walker
Reported 2011-01-13 18:01:19 PST
[chromium] Tiled compositor should use texture manager
Attachments
Patch (10.28 KB, patch)
2011-01-14 13:52 PST, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2011-01-13 18:03:37 PST
This is a needed first step prior to tiling the content and image layers. This change will get the root layer's behavior closer to how these other layers behave.
Adrienne Walker
Comment 2 2011-01-14 13:52:13 PST
Created attachment 78992 [details] Patch
Kenneth Russell
Comment 3 2011-01-14 14:04:34 PST
Comment on attachment 78992 [details] Patch Looks good as far as I can tell from code inspection. Please make sure these changes are fully tested in the browser as well as with the automated tests.
Adrienne Walker
Comment 4 2011-01-14 14:59:07 PST
Yeah, I know our compositing testing infrastructure is not the best yet, so I did a number of manual browser tests (which the ChangeLog entry was too narrow to contain). I opened up a number of pages (in the same render process) that used the compositor, resized the browser, switched tabs, closed tabs, and made sure both scrollbars still behaved as expected.
WebKit Commit Bot
Comment 5 2011-01-19 14:29:21 PST
Comment on attachment 78992 [details] Patch Clearing flags on attachment: 78992 Committed r76165: <http://trac.webkit.org/changeset/76165>
WebKit Commit Bot
Comment 6 2011-01-19 14:29:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.