Bug 5239

Summary: Viewing a particular SVG image causes Safari+SVG to stop responding.
Product: WebKit Reporter: Tobin Richard <tjrichard>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://upload.wikimedia.org/wikipedia/en/0/01/Eye.svg
Attachments:
Description Flags
Stop da loop
none
stop da loop II
eric: review+
More informative error reporting none

Tobin Richard
Reported 2005-10-02 19:58:20 PDT
Attempting to open http://upload.wikimedia.org/wikipedia/en/0/01/Eye.svg (linked to from http://en.wikipedia.org/wiki/Image:Eye.svg) causes Safari+SVG (latest build from 2005-09-03) to stop responding.
Attachments
Stop da loop (514 bytes, patch)
2005-10-03 00:28 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
stop da loop II (583 bytes, patch)
2005-10-03 01:08 PDT, Rob Buis 		eric: review+
DetailsFormatted DiffDiff
More informative error reporting (704 bytes, patch)
2005-10-03 01:24 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-10-02 23:34:46 PDT
Wow, thanks for the bug! It looks like SVGPathParser::parseSVG( const QString &s, bool process ) is just not robust enough. This particular SVG has a non-ascii character right in the middle of a pata data attribute string, and it's causing parseSVG to just loop forever. I'll talk this one out with the KSVG2 guys and see if we can't come up with a fix.
Rob Buis
Comment 2 2005-10-03 00:26:58 PDT
(In reply to comment #0) > Attempting to open http://upload.wikimedia.org/wikipedia/en/0/01/Eye.svg (linked > to from http://en.wikipedia.org/wiki/Image:Eye.svg) causes Safari+SVG (latest > build from 2005-09-03) to stop responding. Good catch! I'll attach a patch that seems to work. I am checking whether just skipping the invalid char is according to svg... Cheers, Rob.
Rob Buis
Comment 3 2005-10-03 00:28:25 PDT
Created attachment 4169 [details] Stop da loop
Rob Buis
Comment 4 2005-10-03 01:08:56 PDT
Created attachment 4174 [details] stop da loop II
Eric Seidel (no email)
Comment 5 2005-10-03 01:10:53 PDT
Comment on attachment 4174 [details] stop da loop II Looks fine. r=me
Rob Buis
Comment 6 2005-10-03 01:24:46 PDT
Created attachment 4175 [details] More informative error reporting
Eric Seidel (no email)
Comment 7 2005-10-03 01:52:45 PDT
Thanks for the great bug!
Note You need to log in before you can comment on or make changes to this bug.