Bug 52365

Summary: Web Inspector: Cleanup after r75613 -- make all UI-facing strings to be passed directly to WebInspector.UIString
Product: WebKit Reporter: Mikhail Naganov <mnaganov@chromium.org>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov@chromium.org>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov@chromium.org, bweinstein@apple.com, joepeck@webkit.org, keishi@webkit.org, loislo@chromium.org, pfeldman@chromium.org, pmuellr@yahoo.com, rik@webkit.org, timothy@apple.com, yurys@chromium.org
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch timothy: review+, mnaganov: commit‑queue-

Description From 2011-01-13 05:50:33 PST
As Timothy suggested, I'm forcing all UI-facing strings to be passed to WebInspector.UIString directly. This removes the need of previously introduced /*@LS*/ annotation.
------- Comment #1 From 2011-01-13 05:54:41 PST -------
Created an attachment (id=78802) [details]
patch

Calling WebInspector.UIString from Number.{bytes|seconds}ToString introduces a run-time dependency of utilities.js on inspector.js, but it's OK for all of the usages, because they happen after WebInspector has been created.
------- Comment #2 From 2011-01-13 07:51:22 PST -------
Manually committed as http://trac.webkit.org/changeset/75714


    2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>

            Reviewed by Timothy Hatcher.

            Web Inspector: Cleanup after r75613 -- make all UI-facing strings
            to be passed directly to WebInspector.UIString

            https://bugs.webkit.org/show_bug.cgi?id=52365

            * English.lproj/localizedStrings.js:
            * inspector/front-end/ApplicationCacheItemsView.js:
            (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
            (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
            * inspector/front-end/AuditRules.js:
            (WebInspector.AuditRules.GzipRule.prototype.doRun):
            (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
            (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
            * inspector/front-end/BreakpointsSidebarPane.js:
            (WebInspector.EventListenerBreakpointsSidebarPane):
            (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
            * inspector/front-end/CookieItemsView.js:
            (WebInspector.CookieItemsView.prototype._updateWithCookies):
            * inspector/front-end/ImageView.js:
            (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
            (WebInspector.ImageView.prototype._createContentIfNeeded):
            * inspector/front-end/NetworkPanel.js:
            (WebInspector.NetworkTimeCalculator.prototype.formatValue):
            (WebInspector.NetworkTransferTimeCalculator.prototype.formatValue):
            (WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
            * inspector/front-end/ProfileDataGridTree.js:
            (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
            (WebInspector.ProfileDataGridNode.prototype.get data):
            * inspector/front-end/Resource.js:
            (WebInspector.Resource.Type.toUIString):
            (WebInspector.Resource.Type.toString):
            * inspector/front-end/TimelineOverviewPane.js:
            (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
            * inspector/front-end/TimelinePanel.js:
            (WebInspector.TimelinePanel):
            (WebInspector.TimelineCalculator.prototype.formatValue):
            (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
            (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
            (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
            * inspector/front-end/utilities.js:
            ():
            * Scripts/check-inspector-strings: