Bug 52323

Summary:

Begin stubbing out some more BackingStore member functions

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2011-01-12 14:21:09 PST

Begin stubbing out some more BackingStore member functions

Comment 1 Anders Carlsson 2011-01-12 14:23:17 PST

Created attachment 78731 [details]
Patch

Comment 2 WebKit Review Bot 2011-01-12 14:26:29 PST

Attachment 78731 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/Ba..." exit_code: 1

WebKit2/UIProcess/BackingStore.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Sam Weinig 2011-01-12 14:29:13 PST

Comment on attachment 78731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78731&action=review

> WebKit2/UIProcess/BackingStore.h:39
> +namespace WebCore {
> +    class IntRect;
> +}

The style checker will not like this.

> WebKit2/UIProcess/BackingStore.h:65
>      WebPageProxy* m_webPageProxy;

It doesn't seem like this should be necessary.

Comment 4 Anders Carlsson 2011-01-12 14:34:42 PST

Committed r75640: <http://trac.webkit.org/changeset/75640>