Bug 52315 – [Qt] Use a big central media play control button for video element

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Yi Shen]

When chrome::requiresFullscreenForVideoPlayback() returns true, all other control buttons for the video element should be hidden, except the play button. When user clicks on the big centralized play button, the video starts playing.

[Yi Shen]

Created attachment 78716 [details]
first try

[Eric Seidel (no email)]

Looks reasonable to me.  CCing video folks in case they want to comment.

[Eric Seidel (no email)]

Comment on attachment 78716 [details]
first try

I don't really know what these controls are supposed to look like, so all I can do is rubber stamp this (which I'm willing to do).  If you have concerns as to if you got the CSS "right" or not, you should ask one of the video folks I CC'd.

[Eric Carlson]

Why don't you split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules in mediaControlsQt.css so you don't have to include duplicate audio::-webkit-media-xxx here? 

As you have it now, you will need to keep mediaControlsQt.css and mediaControlsQtFullscreen.css in sync whenever you change the style of an <audio> element.

[Yi Shen]

Created attachment 78719 [details]
screenshot

[Yi Shen]

(In reply to comment #4)
> Why don't you split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules in mediaControlsQt.css so you don't have to include duplicate audio::-webkit-media-xxx here? 
> 
> As you have it now, you will need to keep mediaControlsQt.css and mediaControlsQtFullscreen.css in sync whenever you change the style of an <audio> element.

Thanks for reviewing, Eric. I think you are right, But if you don't mind, I will split it in a separate bug when I got time (just after I finished bug 51248, which has the highest priority for me). Thanks again :)

[Eric Seidel (no email)]

Comment on attachment 78716 [details]
first try

removing from the cq to allow further discussion.

[Yi Shen]

(In reply to comment #6)
> (In reply to comment #4)
> > Why don't you split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules in mediaControlsQt.css so you don't have to include duplicate audio::-webkit-media-xxx here? 
> > 
> > As you have it now, you will need to keep mediaControlsQt.css and mediaControlsQtFullscreen.css in sync whenever you change the style of an <audio> element.
> 
> Thanks for reviewing, Eric. I think you are right, But if you don't mind, I will split it in a separate bug when I got time (just after I finished bug 51248, which has the highest priority for me). Thanks again :)

Sorry, I mean bug 51249.

[Andreas Kling]

Comment on attachment 78716 [details]
first try

cq=me, Yi will clean up the CSS later on :)

[WebKit Commit Bot]

Comment on attachment 78716 [details]
first try

Clearing flags on attachment: 78716

Committed r75711: <http://trac.webkit.org/changeset/75711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ademar Reis]

Revision r75711 cherry-picked into qtwebkit-2.2 with commit ff08dd9 <http://gitorious.org/webkit/qtwebkit/commit/ff08dd9>