Bug 5231

Summary: attributes don't return correct values for namespaceURI and localName
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: DOMAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Implement localName and namespaceURI for documents
eric: review+
Test case
none
Correct patch eric: review+

Anders Carlsson
Reported 2005-10-02 04:15:24 PDT
namespaceURI and localName aren't implemented for AttrImpl nodes.
Attachments
Implement localName and namespaceURI for documents (2.11 KB, patch)
2005-10-02 04:20 PDT, Anders Carlsson 		eric: review+
DetailsFormatted DiffDiff
Test case (2.11 KB, patch)
2005-10-02 04:21 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Correct patch (2.78 KB, patch)
2005-10-02 04:22 PDT, Anders Carlsson 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2005-10-02 04:20:49 PDT
Created attachment 4143 [details] Implement localName and namespaceURI for documents
Anders Carlsson
Comment 2 2005-10-02 04:21:13 PDT
Created attachment 4144 [details] Test case
Anders Carlsson
Comment 3 2005-10-02 04:22:03 PDT
Created attachment 4145 [details] Correct patch
Eric Seidel (no email)
Comment 4 2005-10-02 10:03:11 PDT
Comment on attachment 4145 [details] Correct patch looks great, r=me. ideally it would have an end-of-file newline, but I'll fix as I'm landing.
Eric Seidel (no email)
Comment 5 2005-10-02 10:03:42 PDT
Comment on attachment 4143 [details] Implement localName and namespaceURI for documents Looks good.
Darin Adler
Comment 6 2005-10-02 21:06:29 PDT
Just call me Mr. Premature Optimization -- I'd have made these inline functions.
Darin Adler
Comment 7 2005-10-02 22:48:45 PDT
Anders landed this but forgot to mark it resolved.
Lucas Forschler
Comment 8 2019-02-06 09:04:10 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.