Bug 52309

Summary:

Expose fixed layout through WebKit SPI

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit API

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, mitz, sam, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch that fixes style-bot errors	none
Patch that stores WebPageCreationParameters	andersca: review+
Getters!	andersca: review+

Beth Dakin

Reported 2011-01-12 10:45:28 PST

We need a way to expose opting into fixed layout in the WebKit SPI. <rdar://problem/8844464>

Attachments
Patch (10.21 KB, patch) 2011-01-12 10:57 PST, Beth Dakin	no flags	Details Formatted Diff Diff
Patch that fixes style-bot errors (10.20 KB, patch) 2011-01-12 11:06 PST, Beth Dakin	no flags	Details Formatted Diff Diff
Patch that stores WebPageCreationParameters (13.27 KB, patch) 2011-01-12 12:27 PST, Beth Dakin	andersca: review+	Details Formatted Diff Diff
Getters! (6.54 KB, patch) 2011-01-12 17:25 PST, Beth Dakin	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2011-01-12 10:57:25 PST

Created attachment 78707 [details] Patch

WebKit Review Bot

Comment 2 2011-01-12 10:59:33 PST

Attachment 78707 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 WebKit2/WebProcess/WebPage/WebPage.h:196: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] WebKit2/UIProcess/WebPageProxy.h:245: The parameter name "fixed" adds no information, so it should be removed. [readability/parameter_name] [5] WebKit2/UIProcess/WebPageProxy.h:246: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Beth Dakin

Comment 3 2011-01-12 11:06:54 PST

Created attachment 78710 [details] Patch that fixes style-bot errors

mitz

Comment 4 2011-01-12 11:10:13 PST

Comment on attachment 78710 [details] Patch that fixes style-bot errors I wonder if we aren’t supposed to keep those values on the UI side so that we can reestablish them after a web process crash, like we do with some of the other WKPage state. Perhaps Sam/Anders can weigh in.

Beth Dakin

Comment 5 2011-01-12 12:27:59 PST

Created attachment 78724 [details] Patch that stores WebPageCreationParameters

Anders Carlsson

Comment 6 2011-01-12 12:31:36 PST

Comment on attachment 78724 [details] Patch that stores WebPageCreationParameters View in context: https://bugs.webkit.org/attachment.cgi?id=78724&action=review > WebKit2/UIProcess/WebPageProxy.cpp:108 > + , m_fixedLayoutSize(IntSize()) No need to initialize m_fixedLayoutSize here.

Beth Dakin

Comment 7 2011-01-12 13:11:58 PST

Fixed with revision 75635.

Beth Dakin

Comment 8 2011-01-12 17:23:52 PST

We decided we need getters too! I will post a patch to add getters in a moment.

Beth Dakin

Comment 9 2011-01-12 17:25:31 PST

Created attachment 78763 [details] Getters!

Beth Dakin

Comment 10 2011-01-12 17:34:55 PST

Thanks Anders! r75662

Note You need to log in before you can comment on or make changes to this bug.