Summary: | Expose fixed layout through WebKit SPI | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||||||
Component: | WebKit API | Assignee: | Beth Dakin <bdakin> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, bdakin, mitz, sam, webkit.review.bot | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Beth Dakin
2011-01-12 10:45:28 PST
Created attachment 78707 [details]
Patch
Attachment 78707 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
WebKit2/WebProcess/WebPage/WebPage.h:196: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5]
WebKit2/UIProcess/WebPageProxy.h:245: The parameter name "fixed" adds no information, so it should be removed. [readability/parameter_name] [5]
WebKit2/UIProcess/WebPageProxy.h:246: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 78710 [details]
Patch that fixes style-bot errors
Comment on attachment 78710 [details]
Patch that fixes style-bot errors
I wonder if we aren’t supposed to keep those values on the UI side so that we can reestablish them after a web process crash, like we do with some of the other WKPage state. Perhaps Sam/Anders can weigh in.
Created attachment 78724 [details]
Patch that stores WebPageCreationParameters
Comment on attachment 78724 [details] Patch that stores WebPageCreationParameters View in context: https://bugs.webkit.org/attachment.cgi?id=78724&action=review > WebKit2/UIProcess/WebPageProxy.cpp:108 > + , m_fixedLayoutSize(IntSize()) No need to initialize m_fixedLayoutSize here. Fixed with revision 75635. We decided we need getters too! I will post a patch to add getters in a moment. Created attachment 78763 [details]
Getters!
Thanks Anders! r75662 |