Bug 52265

Summary: REGRESSION (r72141): Very Slow Rendering With Certain Markup
Product: WebKit Reporter: John Hilliard <praetoriansentry>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, enrica, hyatt, mitz, rniwa
Priority: P1 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://code.google.com/p/chromium/issues/detail?id=69317
Attachments:
Description Flags
The file that causes the error
none
sample of r75294
none
Prevent a negative-max-height line from reordering lines and tripping integer overflow logic adele: review+

John Hilliard
Reported 2011-01-11 17:27:00 PST
Created attachment 78630 [details] The file that causes the error What steps will reproduce the problem? 1. Open the attached file What is the expected result? The page should load and show the wikipedia log and the word blah. What happens instead? The page takes a really long time to load. If/when it does load, the page is blank I noticed this error when working with chrome. It happens with chrome version 9 and 10. When I load the test page in safari 5 it works fine. When I load it using the webkit nightly build, it has the same bad behavior as chrome. If the doctype is change to HTML instead of XHTML it actually works fine. If you remove the doctype all together, the error persists. In the URL i have linked to the bug report that i previously filed on the chrome page
Attachments
The file that causes the error (656 bytes, text/html)
2011-01-11 17:27 PST, John Hilliard 		no flags
Details
sample of r75294 (40.18 KB, text/plain)
2011-01-12 11:33 PST, Alexey Proskuryakov 		no flags
Details
Prevent a negative-max-height line from reordering lines and tripping integer overflow logic (20.37 KB, patch)
2011-01-20 12:29 PST, mitz 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-01-11 23:53:08 PST
Confirmed with r75357. Spinning in findNextLineBreak/skipLeadingWhitespace.
Ryosuke Niwa
Comment 2 2011-01-12 00:22:29 PST
Reproduces on r72146 but does not reproduce on r71897.
Ryosuke Niwa
Comment 3 2011-01-12 00:26:34 PST
The only change set that touches editing between this delta is http://trac.webkit.org/changeset/71898/ but it's very unlikely that this change affected the behavior of findNextLineBreak/skipLeadingWhitespace.
Alexey Proskuryakov
Comment 4 2011-01-12 11:33:16 PST
Created attachment 78714 [details] sample of r75294
Alexey Proskuryakov
Comment 5 2011-01-12 11:43:31 PST
Regressed in r72141 ("font-size:0 is ignored").
Alexey Proskuryakov
Comment 6 2011-01-19 21:46:33 PST
See also: bug 52765.
Alexey Proskuryakov
Comment 7 2011-01-19 21:47:03 PST
<rdar://problem/8890909>
mitz
Comment 8 2011-01-20 12:20:51 PST
*** Bug 52765 has been marked as a duplicate of this bug. ***
mitz
Comment 9 2011-01-20 12:29:23 PST
Created attachment 79633 [details] Prevent a negative-max-height line from reordering lines and tripping integer overflow logic
Adele Peterson
Comment 10 2011-01-20 12:34:21 PST
Comment on attachment 79633 [details] Prevent a negative-max-height line from reordering lines and tripping integer overflow logic View in context: https://bugs.webkit.org/attachment.cgi?id=79633&action=review > Source/WebCore/ChangeLog:21 > + cannot start above this line. The nagative maxHeight also caused the integer overflow detection typo - "nagative"
mitz
Comment 11 2011-01-20 12:50:32 PST
Fixed in r76273. http://trac.webkit.org/changeset/76273
Note You need to log in before you can comment on or make changes to this bug.