Bug 52232

Summary:

[chromium] copy test netscape plugin into TestNetscapePlugin

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Tony Chang

Reported 2011-01-11 12:07:31 PST

[chromium] copy test netscape plugin into TestNetscapePlugin

Attachments
Patch (4.95 KB, patch) 2011-01-11 12:09 PST, Tony Chang	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2011-01-11 12:09:04 PST

Created attachment 78574 [details] Patch

Tony Chang

Comment 2 2011-01-11 12:12:56 PST

We used to have 2 test plugins: TestNetscapePlugIn (the chromium fork) and WebKitTestNetscapePlugIn (the version from upstream). I deleted the chromium fork, but now want to rename WebKitTestNetscapePlugIn to TestNetscapePlugIn to match Mac DRT. On the chromium side, we blacklist TestNetscapePlugIn, because it was the forked plugin that we didn't want. So here's the plan to avoid breakage: 1) Put the upstream plugin in both TestNetscapePlugIn and WebKitTestNetscapePlugIn. (this patch) 2) Roll this patch into chromium. 3) Update the blacklist in chromium to blacklist WebKitTestNetscapePlugIn and use TestNetscapePlugIn 4) Remove WebKitTestNetscapePlugIn in webkit.gyp and fix up the test.

Eric Seidel (no email)

Comment 3 2011-01-11 13:54:41 PST

Comment on attachment 78574 [details] Patch OK.

WebKit Commit Bot

Comment 4 2011-01-11 15:36:11 PST

Comment on attachment 78574 [details] Patch Clearing flags on attachment: 78574 Committed r75561: <http://trac.webkit.org/changeset/75561>

WebKit Commit Bot

Comment 5 2011-01-11 15:36:16 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.