Summary: | Code cleaning in rendering/mathml/RenderMathMLFraction.cpp | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | François Sausset <sausset> | ||||||||
Component: | MathML | Assignee: | Patrick R. Gansterer <paroga> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, buildbot, commit-queue, darin, eric, fred.wang, gustavo, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.6 | ||||||||||
Attachments: |
|
Description
François Sausset
2011-01-11 02:45:26 PST
Created attachment 78506 [details]
Patch
Comment on attachment 78506 [details]
Patch
OK. rs=me.
Comment on attachment 78506 [details] Patch Clearing flags on attachment: 78506 Committed r75487: <http://trac.webkit.org/changeset/75487> All reviewed patches have been landed. Closing bug. Rolled out in r75490 since it broke the 32-bit build. Created attachment 78927 [details]
Patch
I wanted to fix this on trunk, but mrowe was faster with rollout ;-)
Attachment 78927 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7599036 Attachment 78927 [details] did not build on win: Build output: http://queues.webkit.org/results/7518034 Attachment 78927 [details] did not build on mac: Build output: http://queues.webkit.org/results/7581037 Comment on attachment 78927 [details]
Patch
EWS build breaks need to be fixed.
Created attachment 79726 [details]
Patch
Comment on attachment 79726 [details]
Patch
Looks fine, although I don’t think the "f" suffixes are needed. They do make the constants into float constants, but since they are initializers for float I know of no significant benefit to them being those. In fact, for integral values I suggest omitting the decimal point as well.
(In reply to comment #12) > (From update of attachment 79726 [details]) > Looks fine, although I don’t think the "f" suffixes are needed. They do make the constants into float constants, but since they are initializers for float I know of no significant benefit to them being those. In fact, for integral values I suggest omitting the decimal point as well. We need the "f" suffix on all numbers. Otherwise some compilers complain. :-/ Comment on attachment 79726 [details] Patch Clearing flags on attachment: 79726 Committed r76368: <http://trac.webkit.org/changeset/76368> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/76368 might have broken Leopard Intel Debug (Build) This broke the build on Leopard because of mixing double with float. Fixed in http://trac.webkit.org/changeset/76375 |