Bug 52201

Summary: Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
Product: WebKit Reporter: François Sausset <sausset>
Component: MathMLAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, commit-queue, darin, eric, fred.wang, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Patch
levin: review-
Patch none

François Sausset
Reported 2011-01-11 02:45:26 PST
Replace unneeded doubles by floats and remove unneeded casts.
Attachments
Patch (2.45 KB, patch)
2011-01-11 02:48 PST, François Sausset 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2011-01-14 05:03 PST, Patrick R. Gansterer 		levin: review-
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2011-01-21 05:34 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
François Sausset
Comment 1 2011-01-11 02:48:28 PST
Created attachment 78506 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-11 03:01:13 PST
Comment on attachment 78506 [details] Patch OK. rs=me.
WebKit Commit Bot
Comment 3 2011-01-11 04:44:24 PST
Comment on attachment 78506 [details] Patch Clearing flags on attachment: 78506 Committed r75487: <http://trac.webkit.org/changeset/75487>
WebKit Commit Bot
Comment 4 2011-01-11 04:44:30 PST
All reviewed patches have been landed. Closing bug.
Mark Rowe (bdash)
Comment 5 2011-01-11 05:18:38 PST
Rolled out in r75490 since it broke the 32-bit build.
Patrick R. Gansterer
Comment 6 2011-01-14 05:03:50 PST
Created attachment 78927 [details] Patch I wanted to fix this on trunk, but mrowe was faster with rollout ;-)
WebKit Review Bot
Comment 7 2011-01-14 05:08:20 PST
Attachment 78927 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7599036
Build Bot
Comment 8 2011-01-14 05:23:49 PST
Attachment 78927 [details] did not build on win: Build output: http://queues.webkit.org/results/7518034
WebKit Review Bot
Comment 9 2011-01-14 05:42:36 PST
Attachment 78927 [details] did not build on mac: Build output: http://queues.webkit.org/results/7581037
David Levin
Comment 10 2011-01-14 08:05:54 PST
Comment on attachment 78927 [details] Patch EWS build breaks need to be fixed.
Patrick R. Gansterer
Comment 11 2011-01-21 05:34:04 PST
Created attachment 79726 [details] Patch
Darin Adler
Comment 12 2011-01-21 11:01:42 PST
Comment on attachment 79726 [details] Patch Looks fine, although I don’t think the "f" suffixes are needed. They do make the constants into float constants, but since they are initializers for float I know of no significant benefit to them being those. In fact, for integral values I suggest omitting the decimal point as well.
Patrick R. Gansterer
Comment 13 2011-01-21 11:14:51 PST
(In reply to comment #12) > (From update of attachment 79726 [details]) > Looks fine, although I don’t think the "f" suffixes are needed. They do make the constants into float constants, but since they are initializers for float I know of no significant benefit to them being those. In fact, for integral values I suggest omitting the decimal point as well. We need the "f" suffix on all numbers. Otherwise some compilers complain. :-/
WebKit Commit Bot
Comment 14 2011-01-21 11:27:56 PST
Comment on attachment 79726 [details] Patch Clearing flags on attachment: 79726 Committed r76368: <http://trac.webkit.org/changeset/76368>
WebKit Commit Bot
Comment 15 2011-01-21 11:28:02 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 16 2011-01-21 11:47:14 PST
http://trac.webkit.org/changeset/76368 might have broken Leopard Intel Debug (Build)
Darin Adler
Comment 17 2011-01-21 11:52:18 PST
This broke the build on Leopard because of mixing double with float. Fixed in http://trac.webkit.org/changeset/76375
Note You need to log in before you can comment on or make changes to this bug.