Summary: | Title of standalone image document includes bogus image dimensions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | WebKit2 | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin | ||||
Priority: | P2 | Keywords: | PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-01-10 13:09:25 PST
Created attachment 78439 [details]
Patch
Comment on attachment 78439 [details]
Patch
Um. I guess rs=me. Crazy.
Committed r75435: <http://trac.webkit.org/changeset/75435> Comment on attachment 78439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78439&action=review > WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:55 > +// Note that because |format| is used as the second paramter to va_start, it cannot be a reference Misspelled parameter here. Comment on attachment 78439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78439&action=review > WebKit2/ChangeLog:5 > + Don't pass a reference type to va_start > + > + C++ says this results in undefined behavior: Makes total sense. The macro uses the "&" operator, which does something surprising with a reference type. |