Bug 52159

Summary: [chromium] simplify complex glyph positioning code
Product: WebKit Reporter: Evan Martin <evan>
Component: New BugsAssignee: Evan Martin <evan>
Status: RESOLVED FIXED    
Severity: Normal CC: simonjam, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tony: review+

Evan Martin
Reported 2011-01-10 11:27:35 PST
[chromium] simplify complex glyph positioning code
Attachments
Patch (6.02 KB, patch)
2011-01-10 11:28 PST, Evan Martin 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2011-01-10 11:28:51 PST
Created attachment 78416 [details] Patch
Evan Martin
Comment 2 2011-01-10 11:40:29 PST
CC someone who touched this code recently
Tony Chang
Comment 3 2011-01-10 11:47:24 PST
Comment on attachment 78416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78416&action=review > WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp:335 > + if (isRTL) { > + for (size_t i = 0; i < m_item.num_glyphs; ++i) { > + m_xPositions[i] += width; > } > } Nit: {} are optional.
Evan Martin
Comment 4 2011-01-10 11:58:18 PST
Committed r75400: <http://trac.webkit.org/changeset/75400>
Note You need to log in before you can comment on or make changes to this bug.