| Summary: | [WK2] Support for ARM's RVCT compiler in WKBase.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Siddharth Mathur <s.mathur> | ||||
| Component: | WebKit2 | Assignee: | Siddharth Mathur <s.mathur> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, commit-queue, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | Other | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 50251 | ||||||
| Attachments: |
|
||||||
Created attachment 78404 [details]
Patch
Comment on attachment 78404 [details]
Patch
OK. rs=me.
CCing Gavin who might know something about ARM. Don't really know anything about this, but would have RS'ed too! The commit-queue encountered the following flaky tests while processing attachment 78404 [details]: security/block-test-no-port.html bug 52164 (author: pam@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 78404 [details] Patch Clearing flags on attachment: 78404 Committed r75404: <http://trac.webkit.org/changeset/75404> All reviewed patches have been landed. Closing bug. |
Similar to Microsoft's compilers, ARM's RVCT (ARMCC) compiler supports __declspec(dllexport) directive to indicate a DLL export. Update WebKit2/Shared/API/c/WKBase.h to reflect this. Additionally, passing ARMCC the GNU compatbility flag causes the __GNUC__ macro to be implicitly defined, so explicitly guard against use of __attribute__((visibility("default"))).