Bug 52116

Summary:

[GTK] Create intermediate libWebCore library

Product:

WebKit

Reporter:

Xan Lopez <xan.lopez>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
libwebcore.diff	none
libwebcore.diff	none

Xan Lopez

Reported 2011-01-08 16:20:29 PST

The recent move of WebCore into the Source directory makes us hit a limitation in the Linux argument length when doing the final link, since all the object files are passed as one string to the linker and each extra "Source/" bloats the end result. To workaround this (for now) create a temporary libWebCore.la library so we can do the linking in stages.

Attachments
libwebcore.diff (5.75 KB, patch) 2011-01-08 16:23 PST, Xan Lopez	no flags	Details Formatted Diff Diff
libwebcore.diff (6.92 KB, patch) 2011-01-08 16:52 PST, Xan Lopez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Xan Lopez

Comment 1 2011-01-08 16:23:50 PST

Created attachment 78334 [details] libwebcore.diff

Xan Lopez

Comment 2 2011-01-08 16:52:21 PST

Created attachment 78335 [details] libwebcore.diff

Martin Robinson

Comment 3 2011-01-08 18:47:23 PST

Comment on attachment 78335 [details] libwebcore.diff This is so sad after all the work we did to get rid of these. :( I suppose it's necessary for the time being though.

Martin Robinson

Comment 4 2011-01-10 00:28:05 PST

Comment on attachment 78335 [details] libwebcore.diff Clearing flags on attachment: 78335 Committed r75362: <http://trac.webkit.org/changeset/75362>

Martin Robinson

Comment 5 2011-01-10 00:28:09 PST

All reviewed patches have been landed. Closing bug.

Martin Robinson

Comment 6 2011-01-10 00:28:36 PST

Landed this to fix the build.

Note You need to log in before you can comment on or make changes to this bug.