| Summary: | [Qt] [WK2] MiniBrowser does not load pages opened in new windows | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Critical | CC: | benjamin, kling, webkit.review.bot | ||||||
| Priority: | P1 | Keywords: | Qt, QtTriaged | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
This is a bug in MiniBrowser, patch coming. Created attachment 78397 [details]
Proposed patch
Comment on attachment 78397 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=78397&action=review > Tools/MiniBrowser/qt/BrowserView.h:40 > + BrowserView(QGraphicsWKView::BackingStoreType, QWKContext* context, QWidget* parent = 0); Dammit Kling, the "context" argument name isn't necessary here. Attachment 78397 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/BrowserView.cpp', u'Tools/MiniBrowser/qt/BrowserView.h', u'Tools/MiniBrowser/qt/BrowserWindow.cpp', u'Tools/MiniBrowser/qt/BrowserWindow.h', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/API/qt/qwkpage.cpp']" exit_code: 1
Tools/MiniBrowser/qt/BrowserView.h:40: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r75373: <http://trac.webkit.org/changeset/75373> Wow, and https://bugs.webkit.org/show_bug.cgi?id=41441 fixes the last case so I have nothing left to do. Amazing job Andreas, thanks for the help. |
Created attachment 78321 [details] test case When opening a page in new window with WebKit 2, the target page is never loaded. The attached test case illustrate 3 cases not working with Minibrowser.