Bug 52092

Summary: [Soup] ResourceHandleSoup does not handle encodedBlobData
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: elima, gustavo, jianli, pnormand, svillar, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 40833    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Martin Robinson 2011-01-07 17:03:44 PST
Blob support was recently turned on my default, but this bug prevents http/tests/local/formdata/send-form-data-with-sliced-file.html from passing when beginDragWithFiles lands.
Comment 1 Martin Robinson 2011-10-01 19:31:54 PDT
Created attachment 109414 [details]
Patch
Comment 2 Martin Robinson 2011-10-01 19:33:31 PDT
Jian, maybe you could take a look at my implementation
Comment 3 Martin Robinson 2011-10-01 19:34:07 PDT
..to verify its sanity.
Comment 4 Martin Robinson 2011-10-02 23:43:57 PDT
*** Bug 54234 has been marked as a duplicate of this bug. ***
Comment 5 Martin Robinson 2011-10-02 23:48:45 PDT
Created attachment 109445 [details]
Patch
Comment 6 Martin Robinson 2011-10-02 23:49:41 PDT
There seems to be a little bit of code to support blob data for synchronous requests as well. I've included that in this patch and unskipped one more test.
Comment 7 Gustavo Noronha (kov) 2011-10-10 12:13:09 PDT
Comment on attachment 109445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109445&action=review

Looks good!

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:597
>      // We have more than one element to upload, and some may be large files,
>      // which we will want to mmap instead of copying into memory

This comment does not hold true anymore, I believe? We don't know that we have more than one element, do we? =)
Comment 8 Martin Robinson 2011-10-11 19:25:45 PDT
Committed r97219: <http://trac.webkit.org/changeset/97219>
Comment 9 Martin Robinson 2011-10-11 19:28:38 PDT
Comment on attachment 109445 [details]
Patch

Thanks for the review! I landed this without the comment (and one more that was wrong).
Comment 10 Martin Robinson 2011-10-26 10:13:36 PDT
*** Bug 68173 has been marked as a duplicate of this bug. ***