Summary: | [Soup] ResourceHandleSoup does not handle encodedBlobData | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | elima, gustavo, jianli, pnormand, svillar, xan.lopez | ||||||
Priority: | P3 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | 40833 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Martin Robinson
2011-01-07 17:03:44 PST
Created attachment 109414 [details]
Patch
Jian, maybe you could take a look at my implementation ..to verify its sanity. *** Bug 54234 has been marked as a duplicate of this bug. *** Created attachment 109445 [details]
Patch
There seems to be a little bit of code to support blob data for synchronous requests as well. I've included that in this patch and unskipped one more test. Comment on attachment 109445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109445&action=review Looks good! > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:597 > // We have more than one element to upload, and some may be large files, > // which we will want to mmap instead of copying into memory This comment does not hold true anymore, I believe? We don't know that we have more than one element, do we? =) Committed r97219: <http://trac.webkit.org/changeset/97219> Comment on attachment 109445 [details]
Patch
Thanks for the review! I landed this without the comment (and one more that was wrong).
*** Bug 68173 has been marked as a duplicate of this bug. *** |