Bug 52050

Summary: Move WebCore to Source
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, dglazkov, eric, gustavo, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 51606    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-01-07 02:12:35 PST
Move WebCore to Source
Attachments
Patch (425.22 KB, patch)
2011-01-07 02:16 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-01-07 02:16:39 PST
Created attachment 78217 [details] Patch
Adam Barth
Comment 2 2011-01-07 02:17:21 PST
Comment on attachment 78217 [details] Patch This patch should contain everything except the actual move.
WebKit Review Bot
Comment 3 2011-01-07 02:19:27 PST
Attachment 78217 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7365028
WebKit Review Bot
Comment 4 2011-01-07 02:21:01 PST
Attachment 78217 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7429008
Adam Barth
Comment 5 2011-01-07 02:22:24 PST
The failures are, of course, expected.
Early Warning System Bot
Comment 6 2011-01-07 02:23:26 PST
Attachment 78217 [details] did not build on qt: Build output: http://queues.webkit.org/results/7409020
Eric Seidel (no email)
Comment 7 2011-01-07 02:32:30 PST
Comment on attachment 78217 [details] Patch We're goign to end up wanting to remove a bunch of these "Source" additions once everything is moved.
Build Bot
Comment 8 2011-01-07 02:52:30 PST
Attachment 78217 [details] did not build on win: Build output: http://queues.webkit.org/results/7365029
Adam Barth
Comment 9 2011-01-07 11:27:28 PST
> We're goign to end up wanting to remove a bunch of these "Source" additions once everything is moved. Yeah. I removed a bunch from JavaScriptCore in this patch. I can try to move everything in one patch, but that seemed harder.
Adam Barth
Comment 10 2011-01-07 13:11:34 PST
This patch also requires this change downstream in Chromium to keep the upstream build compiling: Index: glue/webkit_glue.gypi =================================================================== --- glue/webkit_glue.gypi (revision 70448) +++ glue/webkit_glue.gypi (working copy) @@ -117,7 +117,7 @@ 'action_name': 'webkit_version', 'inputs': [ '../build/webkit_version.py', - '<(webkit_src_dir)/WebCore/Configurations/Version.xcconfig', + '<(webkit_src_dir)/Source/WebCore/Configurations/Version.xcconfig', ], 'outputs': [ '<(INTERMEDIATE_DIR)/webkit_version.h',
Adam Barth
Comment 11 2011-01-08 01:35:32 PST
Committed r75313: <http://trac.webkit.org/changeset/75313>
WebKit Review Bot
Comment 12 2011-01-08 02:27:49 PST
http://trac.webkit.org/changeset/75313 might have broken Chromium Mac Release
Adam Barth
Comment 13 2011-01-08 02:42:40 PST
(In reply to comment #12) > http://trac.webkit.org/changeset/75313 might have broken Chromium Mac Release This was an expected consequence of a circular dependency on the location of WebCore in the Chromium build system. Hopefully should be resolved now.
Note You need to log in before you can comment on or make changes to this bug.