Bug 52015

Summary: File::Spec->rel2abs in sunspider-compare-results mangles parameters
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
sunspidercompare.diff none

Xan Lopez
Reported 2011-01-06 13:50:31 PST
The script calls that method to convert relative paths into absolute paths early on, breaking the platform detection code since it changes, say, --gtk into /a/path/here/--gtk. We need to call this after the code that detects the platform has been run.
Attachments
sunspidercompare.diff (2.03 KB, patch)
2011-01-06 13:52 PST, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2011-01-06 13:52:22 PST
Created attachment 78157 [details] sunspidercompare.diff
Xan Lopez
Comment 2 2011-01-06 14:01:51 PST
Comment on attachment 78157 [details] sunspidercompare.diff Landed in r75197.
Xan Lopez
Comment 3 2011-01-06 14:02:01 PST
Closing.
Note You need to log in before you can comment on or make changes to this bug.