Bug 52014

Summary: [Qt] GraphicsContext::drawConvexPolygon() has unnecessary code for shadow
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, commit-queue, kenneth, kling, mdelaney7
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Helder Correia
Reported 2011-01-06 13:48:34 PST
The function is only used by RenderObject to draw box sides. The shadow branch is never used and thus can be removed.
Attachments
Patch (1.86 KB, patch)
2011-01-06 13:50 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2011-01-06 13:50:26 PST
Created attachment 78156 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-01-06 14:10:04 PST
Comment on attachment 78156 [details] Patch Covered by tests I suppose?
Ariya Hidayat
Comment 3 2011-01-06 14:29:09 PST
Comment on attachment 78156 [details] Patch cq+
WebKit Commit Bot
Comment 4 2011-01-06 16:08:46 PST
Comment on attachment 78156 [details] Patch Clearing flags on attachment: 78156 Committed r75207: <http://trac.webkit.org/changeset/75207>
WebKit Commit Bot
Comment 5 2011-01-06 16:08:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.