Bug 52010 – [Qt] Plugin API to support platform's input widgets.

• Component: Layout and Rendering
• Status: RESOLVED INVALID

[Ragner Magalhaes]

On mobile platforms, QtWebKit should enable the user to bring up the platform's date, time or date and time picker widgets.

[Kenneth Rohde Christiansen]

We kind of support this with WebKit2 already, by adding some additional InputMethodHints. The user than then reimplement:

virtual void	inputMethodEvent ( QInputMethodEvent * event )

and popup the pickers, sending events just like the virtual keyboard (they are input fields after all)

[Ragner Magalhaes]

Created attachment 78185 [details]
Patch 01

[Ragner Magalhaes]

Created attachment 78186 [details]
Color plugin

[Andreas Kling]

Comment on attachment 78185 [details]
Patch 01

View in context: https://bugs.webkit.org/attachment.cgi?id=78185&action=review

I really don't like using strings for determining the tag names and input types, can we extend QWebElement to expose the WebCore InputType somehow?

> WebKit/qt/Api/qwebkitplatformplugin.h:122
> +    virtual ~QWebInputView() {}

Coding style, {} -> { }

> WebKit/qt/Api/qwebkitplatformplugin.h:125
> +    virtual void setWebElement(QWebElement) = 0;

QWebElement -> const QWebElement&

> WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:691
> +    if (element.isNull() || element.tagName() != "INPUT")

"INPUT" should be wrapped in a QLatin1String. Also, the tagName() may not be all-uppercase, in non-HTML documents for example.

> WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:696
> +    QWebInputView* result = 0;
> +
> +    result = m_platformPlugin.createInputView(element.attribute("type"));

No need for the temporary 0 assignment.
"type" should be wrapped in a QLatin1String.

> WebKit/qt/WebCoreSupport/ChromeClientQt.h:188
> +        QWebInputView *createInputView(QWebElement) const;

QWebElement -> const QWebElement&

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.