Summary: | WKView on Windows has no equivalent of Mac's -[WKView setDraws[Transparent]Background:] | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | WebKit2 | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | adachan, andersca, sam | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-01-06 12:38:03 PST
Created attachment 92319 [details]
Patch
Comment on attachment 92319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92319&action=review > Source/WebKit2/UIProcess/win/WebView.cpp:642 > -static void drawPageBackground(HDC dc, const RECT& rect) > +static void drawPageBackground(HDC dc, const WebPageProxy* page, const RECT& rect) > { > - // Mac checks WebPageProxy::drawsBackground and > - // WebPageProxy::drawsTransparentBackground here, but those are always false on > - // Windows currently (see <http://webkit.org/b/52009>). > + if (!page->drawsBackground() || page->drawsTransparentBackground()) > + return; > + > ::FillRect(dc, &rect, reinterpret_cast<HBRUSH>(COLOR_WINDOW + 1)); > } Failing to paint parts of the HWND will lead to pixel smearing when Aero is disabled. That doesn't seem good! Comment on attachment 92319 [details]
Patch
I guess this will perhaps someday be useful if we add a way to make a WS_EX_LAYERED WKView. Maybe we'll find other uses for it before then.
Committed r85794: <http://trac.webkit.org/changeset/85794> |