Bug 51970

Summary: check-webkit-style should allow unnecessary parameter names in WebKit2 APIs
Product: WebKit Reporter: Jeff Miller <jeffm>
Component: WebKit2Assignee: Jeff Miller <jeffm>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jeff Miller
Reported 2011-01-05 16:50:54 PST
check=webkit-style should allow parameter names in WebKit2 APIs
Attachments
Patch (1.09 KB, patch)
2011-01-05 16:54 PST, Jeff Miller 		no flags
DetailsFormatted DiffDiff
Patch (1.14 KB, patch)
2011-01-05 17:03 PST, Jeff Miller 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2011-01-05 17:07 PST, Jeff Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jeff Miller
Comment 1 2011-01-05 16:54:12 PST
Created attachment 78064 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-01-05 16:55:50 PST
Comment on attachment 78064 [details] Patch You should update the comment above this section to explain why we allow "unnecessary" parameter names. (It's because we're matching CF's header style.)
Jeff Miller
Comment 3 2011-01-05 17:03:06 PST
Created attachment 78070 [details] Patch
Jeff Miller
Comment 4 2011-01-05 17:07:15 PST
Created attachment 78072 [details] Patch
Jeff Miller
Comment 5 2011-01-05 17:07:39 PST
OK, both the change log and comments in the script have been updated.
David Levin
Comment 6 2011-01-05 18:22:39 PST
*** Bug 51938 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 7 2011-01-05 20:09:35 PST
Comment on attachment 78072 [details] Patch Clearing flags on attachment: 78072 Committed r75132: <http://trac.webkit.org/changeset/75132>
WebKit Commit Bot
Comment 8 2011-01-05 20:09:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.