Bug 51956

Summary: [chromium] refactor complex text on Linux
Product: WebKit Reporter: Evan Martin <evan>
Component: New BugsAssignee: Evan Martin <evan>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, evan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch tony: review+

Evan Martin
Reported 2011-01-05 14:23:10 PST
[chromium] refactor complex text on Linux
Attachments
Patch (59.12 KB, patch)
2011-01-05 14:24 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
Patch (60.71 KB, patch)
2011-01-05 14:35 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
Patch (60.86 KB, patch)
2011-01-05 14:52 PST, Evan Martin 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2011-01-05 14:24:57 PST
Created attachment 78043 [details] Patch
Evan Martin
Comment 2 2011-01-05 14:26:05 PST
Note: please don't review the new code -- I don't want to make any changes to it, just relocate it. But please do review the edges of the new file to verify I got the license header and #includes and namespaces right.
WebKit Review Bot
Comment 3 2011-01-05 14:31:31 PST
Attachment 78043 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7308381
Evan Martin
Comment 4 2011-01-05 14:35:16 PST
Created attachment 78046 [details] Patch
David Levin
Comment 5 2011-01-05 14:39:25 PST
Comment on attachment 78046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78046&action=review PLs consider addressing the nits noted. > WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h:34 > +#include "Font.h" Can't you just get by with fwd decls for Font, FontPlatformData, SimpleFontData, TextRun? > WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h:37 > +#include <wtf/OwnArrayPtr.h> missing include for OwnPtr.
Evan Martin
Comment 6 2011-01-05 14:52:23 PST
Created attachment 78050 [details] Patch
Evan Martin
Comment 7 2011-01-05 15:17:42 PST
Committed r75108: <http://trac.webkit.org/changeset/75108>
Note You need to log in before you can comment on or make changes to this bug.