Bug 51931

Summary: Keep track of active text substitution preferences
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2011-01-05 10:07:04 PST
Keep track of active text substitution preferences
Attachments
Patch (15.03 KB, patch)
2011-01-05 10:10 PST, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-05 10:10:05 PST
Created attachment 78013 [details] Patch
mitz
Comment 2 2011-01-05 10:17:53 PST
Comment on attachment 78013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78013&action=review > WebKit2/UIProcess/API/mac/WKView.mm:544 > + if (flag == TextChecker::state().isAutomaticDashSubstitutionEnabled) Is it safe to compare a BOOL with a bool like this?
Darin Adler
Comment 3 2011-01-05 10:21:48 PST
Comment on attachment 78013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78013&action=review > WebKit2/UIProcess/API/mac/WKView.mm:386 > + Strange blank line here.
Anders Carlsson
Comment 4 2011-01-05 10:28:35 PST
Committed r75079: <http://trac.webkit.org/changeset/75079>
Note You need to log in before you can comment on or make changes to this bug.