Bug 51931

Summary:

Keep track of active text substitution preferences

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mitz: review+

Description Anders Carlsson 2011-01-05 10:07:04 PST

Keep track of active text substitution preferences

Comment 1 Anders Carlsson 2011-01-05 10:10:05 PST

Created attachment 78013 [details]
Patch

Comment 2 mitz 2011-01-05 10:17:53 PST

Comment on attachment 78013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78013&action=review

> WebKit2/UIProcess/API/mac/WKView.mm:544
> +    if (flag == TextChecker::state().isAutomaticDashSubstitutionEnabled)

Is it safe to compare a BOOL with a bool like this?

Comment 3 Darin Adler 2011-01-05 10:21:48 PST

Comment on attachment 78013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78013&action=review

> WebKit2/UIProcess/API/mac/WKView.mm:386
> +

Strange blank line here.

Comment 4 Anders Carlsson 2011-01-05 10:28:35 PST

Committed r75079: <http://trac.webkit.org/changeset/75079>