Bug 51929

Summary:

[Qt][V8] ScriptCachedFrameData.cpp misses V8DOMWindowShell::setContext

Product:

WebKit

Reporter:

Andras Becsi <abecsi>

Component:

WebCore Misc.

Assignee:

Andras Becsi <abecsi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, andreip, antonm, eric, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

51930

Bug Blocks:

Attachments:

Description	Flags
proposed fix	none

Andras Becsi

Reported 2011-01-05 08:48:22 PST

After http://trac.webkit.org/changeset/74778 QtWebKit-V8 does not build because of the missing V8DOMWindowShell::setContext method, which was originally introduced in http://trac.webkit.org/changeset/56716.

Attachments
proposed fix (1.82 KB, patch) 2011-01-05 09:04 PST, Andras Becsi	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andrei Popescu

Comment 1 2011-01-05 08:52:30 PST

Oh, Android uses that method to enable WebKit's page cache mechanism so the method *is* used. Anton, please roll back your change :)

Andras Becsi

Comment 2 2011-01-05 09:04:36 PST

Created attachment 78008 [details] proposed fix I'm not really sure whether this is the right way to fix the issue, maybe someone who is more familiar with V8 bindings can help.

Andras Becsi

Comment 3 2011-01-05 09:06:15 PST

(In reply to comment #1) > Oh, Android uses that method to enable WebKit's page cache mechanism so the method *is* used. Anton, please roll back your change :) Ah OK. Thanks for the help.

Andrei Popescu

Comment 4 2011-01-05 09:08:14 PST

(In reply to comment #2) > Created an attachment (id=78008) [details] > proposed fix > > I'm not really sure whether this is the right way to fix the issue, maybe someone who is more familiar with V8 bindings can help. I don't think that's the right fix. We should simply roll back Anton's change, IMHO.

Andras Becsi

Comment 5 2011-01-05 09:11:44 PST

(In reply to comment #4) > (In reply to comment #2) > > Created an attachment (id=78008) [details] [details] > > proposed fix > > > > I'm not really sure whether this is the right way to fix the issue, maybe someone who is more familiar with V8 bindings can help. > > I don't think that's the right fix. We should simply roll back Anton's change, IMHO. OK, sheriffbot can do that.

Andras Becsi

Comment 6 2011-01-05 09:44:24 PST

The issue was fixed by reverting the changes in http://trac.webkit.org/changeset/75073.

anton muhin

Comment 7 2011-01-11 07:51:41 PST

Sorry for the trouble. May I have a look how you use this method? (In reply to comment #6) > The issue was fixed by reverting the changes in http://trac.webkit.org/changeset/75073.

Andrei Popescu

Comment 8 2011-01-11 08:23:38 PST

(In reply to comment #7) > Sorry for the trouble. > > May I have a look how you use this method? > > (In reply to comment #6) > > The issue was fixed by reverting the changes in http://trac.webkit.org/changeset/75073. If I remember right, it's called from here: http://trac.webkit.org/browser/trunk/WebCore/bindings/v8/ScriptCachedFrameData.cpp?rev=56716#L58 Thanks, Andrei

anton muhin

Comment 9 2011-01-12 11:46:28 PST

Thanks a lot! (In reply to comment #8) > (In reply to comment #7) > > Sorry for the trouble. > > > > May I have a look how you use this method? > > > > (In reply to comment #6) > > > The issue was fixed by reverting the changes in http://trac.webkit.org/changeset/75073. > > If I remember right, it's called from here: > > http://trac.webkit.org/browser/trunk/WebCore/bindings/v8/ScriptCachedFrameData.cpp?rev=56716#L58 > > Thanks, > Andrei

Note You need to log in before you can comment on or make changes to this bug.