Bug 51907

Summary: Style selector should only be recalculated when the pending sheet count goes to zero
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch mitz: review+

Antti Koivisto
Reported 2011-01-04 16:25:59 PST
Currently the style selector it recalculated whenever a new stylesheet arrives from the network, even when there are other stylesheet load pending. We don't apply the style nor run scripts before the pending count goes to zero, so we can delay the style selector recalculation until that point too.
Attachments
patch (1.35 KB, patch)
2011-01-04 16:33 PST, Antti Koivisto 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2011-01-04 16:33:48 PST
Created attachment 77945 [details] patch Shark says this is a significant performance improvement on some sites with lots of stylesheets. For example in Facebook the time spent in style resolve during page loading is reduced by >30%.
mitz
Comment 2 2011-01-04 16:45:01 PST
Comment on attachment 77945 [details] patch r=me assuming all tests pass
Alexey Proskuryakov
Comment 3 2011-01-04 17:17:16 PST
Nice!
Antti Koivisto
Comment 4 2011-01-05 04:06:04 PST
http://trac.webkit.org/changeset/75058
Note You need to log in before you can comment on or make changes to this bug.