Bug 51888

Summary:

[Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hausmann, koshuin, laszlo.gombos

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

S60 3rd edition

Attachments:

Description	Flags
proposed patch	none

Laszlo Gombos

Reported 2011-01-04 12:31:01 PST

Currently CONFIG(def_files) (almost always) evaluates to true as that is the default in Qt's qconfig.pri. This can be overruled at qmake time by changing the CONFIG variable. This means that (more often than not) the QtWebKit trunk build fails as the def file is not up-to-date. The current practice is to always pass CONFIG-=def_files for QtWebKit trunk builds. CONFIG(production) has been introduced as a single bit to switch between the somewhat unstable trunk environment to a more stable production environment. CONFIG(production) evaluates to true on production branches of QtWebKit and false on the trunk. It seems like a good idea to overrule Qt's default from qconfig.pri for non-production builds so that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeeds.

Attachments
proposed patch (1.13 KB, patch) 2011-01-04 12:34 PST, Laszlo Gombos	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2011-01-04 12:34:49 PST

Created attachment 77916 [details] proposed patch

Ariya Hidayat

Comment 2 2011-01-05 09:07:21 PST

Comment on attachment 77916 [details] proposed patch LGTM. re=me

WebKit Commit Bot

Comment 3 2011-01-05 09:55:26 PST

Comment on attachment 77916 [details] proposed patch Clearing flags on attachment: 77916 Committed r75076: <http://trac.webkit.org/changeset/75076>

WebKit Commit Bot

Comment 4 2011-01-05 09:55:33 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.