Summary: | [Chromium] svg/custom/fill-SVGPaint-interface.svg and svg/custom/getPresentationAttribute.svg marked as WONTFIX SKIP but bug causing test failure fixed. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shane Stephens <shanestephens> | ||||
Component: | New Bugs | Assignee: | Shane Stephens <shanestephens> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Shane Stephens
2011-01-03 20:00:19 PST
Created attachment 77866 [details]
Patch
Comment on attachment 77866 [details]
Patch
Oh yeah, wow, that was a long ago bug!
Comment on attachment 77866 [details] Patch Rejecting attachment 77866 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--no-update', '--non-interactive', 77866]" exit_code: 2 Last 500 characters of output: romium-linux/svg/custom/getPresentationAttribute-expected.checksum patching file LayoutTests/platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt patching file LayoutTests/platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.checksum only literal type is supported now at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 248. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 29 Full output: http://queues.webkit.org/results/7293369 Any idea why webkit-patch is generating delta patches (which svn-apply doesn't accept) here? webkit-patch depends on scm.py, which currently uses the following for git: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm.py#L728 Unfortunately I know of no way to force literal patches in Git. See https://bugs.webkit.org/show_bug.cgi?id=38864 about adding delta support to svn-apply. Could someone see about getting this back on the commit queue once the patch fixing 38864 has arrived there? I cannot thank you enough for the delta fix! Comment on attachment 77866 [details] Patch Clearing flags on attachment: 77866 Committed r75482: <http://trac.webkit.org/changeset/75482> All reviewed patches have been landed. Closing bug. |