Bug 51865

Summary:

[Chromium] svg/custom/fill-SVGPaint-interface.svg and svg/custom/getPresentationAttribute.svg marked as WONTFIX SKIP but bug causing test failure fixed.

Product:

WebKit

Reporter:

Shane Stephens <shanestephens>

Component:

New Bugs

Assignee:

Shane Stephens <shanestephens>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Shane Stephens

Reported 2011-01-03 20:00:19 PST

[Chromium] Tests marked as WONTFIX SKIP but bug causing test failure fixed.

Attachments
Patch (38.35 KB, patch) 2011-01-03 20:01 PST, Shane Stephens	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Shane Stephens

Comment 1 2011-01-03 20:01:20 PST

Created attachment 77866 [details] Patch

Eric Seidel (no email)

Comment 2 2011-01-03 23:42:39 PST

Comment on attachment 77866 [details] Patch Oh yeah, wow, that was a long ago bug!

WebKit Commit Bot

Comment 3 2011-01-03 23:44:32 PST

Comment on attachment 77866 [details] Patch Rejecting attachment 77866 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-attachment', '--no-update', '--non-interactive', 77866]" exit_code: 2 Last 500 characters of output: romium-linux/svg/custom/getPresentationAttribute-expected.checksum patching file LayoutTests/platform/chromium-linux/svg/custom/getPresentationAttribute-expected.txt patching file LayoutTests/platform/chromium-win/svg/custom/fill-SVGPaint-interface-expected.checksum only literal type is supported now at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 248. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 29 Full output: http://queues.webkit.org/results/7293369

Shane Stephens

Comment 4 2011-01-04 16:26:57 PST

Any idea why webkit-patch is generating delta patches (which svn-apply doesn't accept) here?

Eric Seidel (no email)

Comment 5 2011-01-04 16:29:00 PST

webkit-patch depends on scm.py, which currently uses the following for git: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm.py#L728 Unfortunately I know of no way to force literal patches in Git.

Eric Seidel (no email)

Comment 6 2011-01-04 16:31:05 PST

See https://bugs.webkit.org/show_bug.cgi?id=38864 about adding delta support to svn-apply.

Shane Stephens

Comment 7 2011-01-07 19:45:56 PST

Could someone see about getting this back on the commit queue once the patch fixing 38864 has arrived there?

Eric Seidel (no email)

Comment 8 2011-01-11 03:08:00 PST

I cannot thank you enough for the delta fix!

WebKit Commit Bot

Comment 9 2011-01-11 03:26:18 PST

Comment on attachment 77866 [details] Patch Clearing flags on attachment: 77866 Committed r75482: <http://trac.webkit.org/changeset/75482>

WebKit Commit Bot

Comment 10 2011-01-11 03:26:25 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.