Summary: | style update not propagating for before, after content for table parts | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Abhishek Arya <inferno> | ||||||
Component: | Layout and Rendering | Assignee: | Chris Evans <cevans> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | abarth, cevans, dglazkov, hyatt, mitz, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Abhishek Arya
2011-01-03 18:46:29 PST
I have a fix for this one. Created attachment 103406 [details]
Patch
Comment on attachment 103406 [details] Patch Attachment 103406 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9333539 New failing tests: fast/css-generated-content/table-table-before-after-child-add.html fast/css-generated-content/table-row-before-after-child-add.html The correct rendering of the two changed image files now matches Firefox. Comment on attachment 103406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103406&action=review > Source/WebCore/ChangeLog:3 > + Style change not propogating for before, after content ->propagating Created attachment 103426 [details]
Fix typo.
Comment on attachment 103426 [details] Fix typo. Rejecting attachment 103426 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: l = IMAGE fast/css-generated-content/table-table-before-after-child-add.html = IMAGE fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE Regressions: Unexpected image and text mismatch : (1) svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT Full output: http://queues.webkit.org/results/9333608 Comment on attachment 103426 [details] Fix typo. Clearing flags on attachment: 103426 Committed r92744: <http://trac.webkit.org/changeset/92744> All reviewed patches have been landed. Closing bug. |