Summary: | LEAK: Deallocate instance of ThreadFunctionInvocation if thread creation fails | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | Web Template Framework | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aroben, eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Attachments: |
|
Description
Daniel Bates
2011-01-03 18:06:17 PST
Created attachment 77857 [details]
Patch
Don't we have a cleaner way to do this? (In reply to comment #2) > Don't we have a cleaner way to do this? One idea was to use OwnPtr, but I was concerned that there might be a race condition between the time we copy the data structure pointed to by param in wtfThreadEntryPoint() and when the OwnPtr goes out of scope when we reach the end of createThreadInternal(). I'll look into this some more. If you have any insight/suggestions I would appreciate it. Created attachment 77904 [details] Patch Use OwnPtr based on a suggestion by Adam Roben for bug #51855 Created attachment 77905 [details]
Patch
Committed r74983: <http://trac.webkit.org/changeset/74983> |