Bug 51842

Summary: check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, hamaji, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

David Levin
Reported 2011-01-03 12:00:17 PST
For example: add(key, value) or more concretely: https://bugs.webkit.org/attachment.cgi?id=77820&action=prettypatch
Attachments
Patch (3.28 KB, patch)
2011-01-03 12:04 PST, David Levin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-01-03 12:04:05 PST
Created attachment 77833 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-03 12:20:57 PST
Comment on attachment 77833 [details] Patch Why not? :)
WebKit Commit Bot
Comment 3 2011-01-03 13:21:42 PST
Comment on attachment 77833 [details] Patch Clearing flags on attachment: 77833 Committed r74934: <http://trac.webkit.org/changeset/74934>
WebKit Commit Bot
Comment 4 2011-01-03 13:21:49 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-01-03 14:07:53 PST
http://trac.webkit.org/changeset/74934 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/remember-bad-password.html
Note You need to log in before you can comment on or make changes to this bug.