Bug 51822

Summary: ContextShadow::blurLayerImage() not endian-safe
Product: WebKit Reporter: fabien.coeurjoly
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, krit, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch none

fabien.coeurjoly
Reported 2011-01-03 08:30:49 PST
On my PowerPC machine, CSS text/box blurred shadows have disappeared since a couple weeks. I investigated a bit and tracked it down to ContextShadow::blurLayerImage() being the culprit, using hardcoded positions for channels: int channels[4] = { 3, 0, 1, 3 }; where it should be int channels[4] = { 0, 3, 2, 0 }; on a big endian machine.
Attachments
Patch (1.73 KB, patch)
2011-01-05 10:24 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-01-05 10:24:53 PST
Created attachment 78015 [details] Patch
Ariya Hidayat
Comment 2 2011-01-05 10:58:22 PST
Comment on attachment 78015 [details] Patch LGTM. re=me
Martin Robinson
Comment 3 2011-01-05 12:37:06 PST
Committed r75095: <http://trac.webkit.org/changeset/75095>
Note You need to log in before you can comment on or make changes to this bug.