Bug 51750 – [Qt]Add local storage settings to QtTestBrowser command line arguments

• Component: Tools / Tests
• Status: RESOLVED FIXED

[suchi]

Following local storage settings can be enable form command line arguments for QtTestBrowser: 

LocalStorageEnabled
 
OfflineStorageDatabaseEnabled

OfflineWebApplicationCacheEnabled
 
setOfflineStorageDefaultQuota(maxsize)

[suchi]

Created attachment 77808 [details]
Patch to enable local storage settings from command line in QtTestBrowser

with this patch user would be able to enable local storage settings from command line for QtTestBrowser

[Andreas Kling]

Comment on attachment 77808 [details]
Patch to enable local storage settings from command line in QtTestBrowser

View in context: https://bugs.webkit.org/attachment.cgi?id=77808&action=review

> WebKit.pri:68
> -linux-g++* {
> -    isEqual(QT_ARCH,x86_64)|isEqual(QT_ARCH,i386): QMAKE_CXXFLAGS += -Werror
> -}
> +#linux-g++* {isEqual(QT_ARCH,x86_64)|isEqual(QT_ARCH,i386): QMAKE_CXXFLAGS += -Werror}

This does not belong in this patch.

> WebKitTools/QtTestBrowser/main.cpp:79
> -    QWebSettings::enablePersistentStorage();
> +    QWebSettings::enablePersistentStorage();    

Unrelated whitespace change.

> WebKitTools/QtTestBrowser/main.cpp:132
> +             << "[-localStorageEnabled]"
> +             << "[-offlineStorageDatabaseEnabled]"
> +             << "[-offlineWebApplicationCacheEnabled]"
> +             << "[-setOfflineStorageDefaultQuota maxSize]"

You should follow the same convention as the existing options, -words-separated-by-dashes

> WebKitTools/QtTestBrowser/main.cpp:168
> +    if (args.contains("-localStorageEnabled")) {
> +        QWebSettings::globalSettings()->setAttribute(QWebSettings::LocalStorageEnabled, true);
> +    }

Coding style, no {} here.

> WebKitTools/QtTestBrowser/main.cpp:172
> +    if (args.contains("-offlineStorageDatabaseEnabled")) {
> +        QWebSettings::globalSettings()->setAttribute(QWebSettings::OfflineStorageDatabaseEnabled, true);
> +    }

Ditto.

> WebKitTools/QtTestBrowser/main.cpp:176
> +    if (args.contains("-offlineWebApplicationCacheEnabled")) {
> +        QWebSettings::globalSettings()->setAttribute(QWebSettings::OfflineWebApplicationCacheEnabled, true);
> +    }

Ditto.

> WebKitTools/QtTestBrowser/main.cpp:179
> +    if (setOfflineStorageDefaultQuotaIndex != -1){

Coding style, space between ) and {.

> WebKitTools/QtTestBrowser/webpage.cpp:50
> -    applyProxy();
> -
> +    applyProxy();    
> +        

Unrelated whitespace change.

[suchi]

Created attachment 77838 [details]
Adding the modified patch as suggested by Andreas Kling

Thanks for the comment, had modified the patch with the suggested change.

[Andreas Kling]

Comment on attachment 77838 [details]
Adding the modified patch as suggested by Andreas Kling

r=me

[WebKit Commit Bot]

Comment on attachment 77838 [details]
Adding the modified patch as suggested by Andreas Kling

Clearing flags on attachment: 77838

Committed r75074: <http://trac.webkit.org/changeset/75074>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.